From: Jeff Moyer <jmoyer@redhat.com>
To: Junxiao Bi <junxiao.bi@oracle.com>
Cc: ocfs2-devel@oss.oracle.com, linux-aio@kvack.org,
mfasheh@suse.com, jlbec@evilplan.org, bcrl@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
joe.jin@oracle.com, dave.kleikamp@oracle.com
Subject: Re: [V2 PATCH 1/2] aio: make kiocb->private NUll in init_sync_kiocb()
Date: Thu, 07 Jun 2012 11:09:26 -0400 [thread overview]
Message-ID: <x49zk8f9n15.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1338881210-14863-2-git-send-email-junxiao.bi@oracle.com> (Junxiao Bi's message of "Tue, 5 Jun 2012 15:26:49 +0800")
Junxiao Bi <junxiao.bi@oracle.com> writes:
> Ocfs2 uses kiocb.*private as a flag of unsigned long size. In
> commit a11f7e6 ocfs2: serialize unaligned aio, the unaligned
> io flag is involved in it to serialize the unaligned aio. As
> *private is not initialized in init_sync_kiocb() of do_sync_write(),
> this unaligned io flag may be unexpectly set in an aligned dio.
> And this will cause OCFS2_I(inode)->ip_unaligned_aio decreased
> to -1 in ocfs2_dio_end_io(), thus the following unaligned dio
> will hang forever at ocfs2_aiodio_wait() in ocfs2_file_aio_write().
>
> Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
Acked-by: Jeff Moyer <jmoyer@redhat.com>
next prev parent reply other threads:[~2012-06-07 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 7:26 [V2]fix ocfs2 aio/dio writing process hang Junxiao Bi
2012-06-05 7:26 ` [V2 PATCH 1/2] aio: make kiocb->private NUll in init_sync_kiocb() Junxiao Bi
2012-06-05 9:31 ` Greg KH
2012-06-07 15:09 ` Jeff Moyer [this message]
2012-06-05 7:26 ` [V2 PATCH 2/2] ocfs2: clear unaligned io flag when dio fails Junxiao Bi
2012-06-05 9:31 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49zk8f9n15.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=bcrl@kvack.org \
--cc=dave.kleikamp@oracle.com \
--cc=jlbec@evilplan.org \
--cc=joe.jin@oracle.com \
--cc=junxiao.bi@oracle.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®