From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754997Ab2BVTmA (ORCPT ); Wed, 22 Feb 2012 14:42:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24574 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751477Ab2BVTl7 (ORCPT ); Wed, 22 Feb 2012 14:41:59 -0500 From: Jeff Moyer To: Vivek Goyal Cc: Tejun Heo , axboe@kernel.dk, ctalbott@google.com, rni@google.com, linux-kernel@vger.kernel.org, Kent Overstreet Subject: Re: [PATCH 34/36] block: implement bio_associate_current() References: <1329875223-5102-1-git-send-email-tj@kernel.org> <1329875223-5102-35-git-send-email-tj@kernel.org> <20120222190750.GA17480@google.com> <20120222193759.GB7635@redhat.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Wed, 22 Feb 2012 14:41:54 -0500 In-Reply-To: <20120222193759.GB7635@redhat.com> (Vivek Goyal's message of "Wed, 22 Feb 2012 14:37:59 -0500") Message-ID: User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vivek Goyal writes: > Currently he has put the bio_associate() hook only in blk_throtl_bio() > which is under CONFIG_BLK_CGROUP. It is agreed upon that this mechanism > looks generally useful and probably submit_bio() is a better place to > put the hook. Tejun mentioned that once things work well, later we can > think of making the functionality more generic. In that case we shall > have to remove the cgroup specific #ifdefs. Thanks for the recap, Vivek! -Jeff