From: Michal Nazarewicz <mina86@mina86.com>
To: Hagen Paul Pfeifer <hagen@jauu.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mark Rustad <mark.d.rustad@intel.com>, "Kirsher\,
Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] include: kernel.h: deduplicate code implementing clamp* macros
Date: Fri, 26 Sep 2014 22:04:27 +0200 [thread overview]
Message-ID: <xa1tvboaywqc.fsf@mina86.com> (raw)
In-Reply-To: <CAPh34mcT1tcWFO316+6dxAEhWc7MzLU0Uq3ATXv4N3cf9z5DHA@mail.gmail.com>
On Thu, Sep 25 2014, Hagen Paul Pfeifer <hagen@jauu.net> wrote:
> On 25 September 2014 17:50, Michal Nazarewicz <mina86@mina86.com> wrote:
>
>> - * @min: minimum allowable value
>> - * @max: maximum allowable value
>> + * @lo: minimum allowable value
>> + * @hi: maximum allowable value
>
> Ok, but why do you rename min/max to low/high after so many years?
> min/max is just perfect
To match argument names of the clamp macro (which got renamed when
rewriting min3, max3 and clamp), but I don't really care either way.
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--
prev parent reply other threads:[~2014-09-26 20:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1409837300.2460.10.camel@jtkirshe-mobl>
2014-09-04 21:38 ` kernel: Resolve a shadow warning Andrew Morton
2014-09-04 23:03 ` Rustad, Mark D
2014-09-11 21:39 ` [PATCH 1/2] include: kernel.h: deduplicate code implementing min*, max* and clamp* macros Michal Nazarewicz
2014-09-11 21:39 ` [PATCH 2/2] kernel.h: use __COUNTER__ in min and max macros to avoid -Wshadow warnings Michal Nazarewicz
2014-09-12 22:40 ` Andrew Morton
2014-09-12 23:37 ` Michal Nazarewicz
2014-09-12 23:48 ` Rustad, Mark D
2014-09-12 23:43 ` Rustad, Mark D
2014-09-13 0:12 ` Andrew Morton
2014-09-25 15:50 ` [PATCH] include: kernel.h: deduplicate code implementing clamp* macros Michal Nazarewicz
2014-09-25 19:46 ` Hagen Paul Pfeifer
2014-09-26 20:04 ` Michal Nazarewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xa1tvboaywqc.fsf@mina86.com \
--to=mina86@mina86.com \
--cc=akpm@linux-foundation.org \
--cc=hagen@jauu.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.d.rustad@intel.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome