Re: [PATCH v4 2/2] phy: qcom-snps-femto-v2: Add support for SA8255P

[Mattijs Korpershoek <mkorpershoek@kernel.org>]

Hi Mani,

On Tue, Oct 27, 2026 at 14:00, Mattijs Korpershoek <mkorpershoek@kernel.org> wrote:

> From: Sriram Dash <quic_sriramd@quicinc.com>
>
> SA8255p platform abstracts resources such as resets, clocks and
> regulators in firmware. The SCMI firmware exposes multiple protocols to
> control such resources which are identified by protocol_id.
>
> For this USB phy, 2 SCMI protocols are exposed by the firmware:
> * power domain management protocol (protocol_id=0x11)
> * performance domain management protocol (protocol_id=0x13)
>
> The power domain has 2 indices: 'core' and 'transfer'.
> * core controls the regulators, the clocks and the reset
> * transfer only controls the clocks
>
> For example, to power on/off the PHY, we should use the 'core' domain.
> To disable data transfer and keeping power enabled, we should use the
> 'transfer' domain.
>
> Add support for the SCMI firmware-managed variant in the driver.
>
> Note: the performance domain (0x13) exposes opaques values (0xa to 0x11)
> for which we don't have any information. Since it is not mandatory
> for the PHY to be functional, we have ommited it from the driver.
>
> Signed-off-by: Sriram Dash <quic_sriramd@quicinc.com>
> Co-developed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
> Signed-off-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

I hope I've addressed all the comments you had on v3.
Could you have a look please?

Thank you for your time.
Mattijs