mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Valentin Schneider <vschneid@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Douglas RAILLARD <douglas.raillard@arm.com>
Subject: Re: [PATCH] tracing: Add __cpumask to denote a trace event field that is a cpumask_t
Date: Mon, 17 Oct 2022 10:38:07 +0100	[thread overview]
Message-ID: <xhsmh5ygiyem8.mognet@vschneid.remote.csb> (raw)
In-Reply-To: <20221015071416.00369347@rorschach.local.home>

On 15/10/22 07:14, Steven Rostedt wrote:
> On Fri, 14 Oct 2022 18:21:41 +0100
> Valentin Schneider <vschneid@redhat.com> wrote:
>> 
>> Thanks for spinning this out so quickly! I gave it a test against my IPI
>> tracepoints, it's working OK with one (expected) change:
>
> No problem. It was my "While traveling I pick what I want to work on" project ;-)
>
>> 
>>   [ipi:ipi_send_cpumask] function __get_cpumask not defined
>>   CPU 0 is empty
>>   CPU 1 is empty
>>   CPU 3 is empty
>>   cpus=4
>>             echo-173   [002]    11.859745: ipi_send_cpumask:     [FAILED TO PARSE] cpumask=ARRAY[02, 00, 00, 00, 00, 00, 00, 00] callsite=0xffffffff81121013
>> 
>> so libtraceevent is going to need updating - I'm happy to do that (if you
>> haven't done it already!)
>
> I have not done that. I'm happy to take a patch from you.
>

I'll go do that and try to mess around the pretty-print output as well.

>> 
>> Lastly, given all cpumasks have a (usable) size of nr_cpumask_bits, we can
>> factor out the size argument, see below. Regardless:
>
> Seems reasonable. I can fold that into my patch and if you reply back
> with your signed-off-by tag, I'll include you as co-author.
>


  reply	other threads:[~2022-10-17  9:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14 12:04 Steven Rostedt
2022-10-14 17:21 ` Valentin Schneider
2022-10-15 11:14   ` Steven Rostedt
2022-10-17  9:38     ` Valentin Schneider [this message]
2022-10-17  9:41     ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xhsmh5ygiyem8.mognet@vschneid.remote.csb \
    --to=vschneid@redhat.com \
    --cc=douglas.raillard@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®