From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8433C433EF for ; Tue, 19 Jul 2022 15:15:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239455AbiGSPPo (ORCPT ); Tue, 19 Jul 2022 11:15:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239100AbiGSPPa (ORCPT ); Tue, 19 Jul 2022 11:15:30 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0200254AE7 for ; Tue, 19 Jul 2022 08:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658243710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DZfape1HvRcQDBJMjqCK8x7O2btj6Zg9uPaKpCKPLz4=; b=OL33YoEyNreN9j043Q3qoxAW+Sf0D2EP+/TkO1ryIzp5Jdlk35C0/AecyBIcK7Me3KDOm+ DODGR8gzEI9u3y3f/g2H9qRkVQ1ZfkQo5sqldOux9Z409233XxUyAa0WiuoBplz8+sgFpe 9z1oKeT4xBS2LVG4ujljxaAOPVPJpfQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-37-r7lCQn3nMO-qsrtrMoEokQ-1; Tue, 19 Jul 2022 11:15:06 -0400 X-MC-Unique: r7lCQn3nMO-qsrtrMoEokQ-1 Received: by mail-wm1-f70.google.com with SMTP id bh18-20020a05600c3d1200b003a32044cc9fso1882010wmb.6 for ; Tue, 19 Jul 2022 08:15:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=DZfape1HvRcQDBJMjqCK8x7O2btj6Zg9uPaKpCKPLz4=; b=RJyVAswlHw3NKGi0OADX7VUnZbKNRFY16lsnqiajC+6Li6QoX1LiFfb/BzyqJBaC9d 1jZ7/B1Uok8fAUnbcROmWzNBEDmHmGRcmpWj7jtx9kzHyV5o2+ZIhqB6Nqz0GC7tjNMp fPhZ9i16cMP6lIK6I0YKb/rbjwTVWDjbjXBRviQcOTzh6oypY6t4XWt5Dkwv6EH6Ff/1 47yBrrB9MTxXtlESlVjFgay7HuazHY9uQz/NtbjxlqGK2W6IhjMo8y+yWEOWRzem69Al b5mv7n6hqFggt1iVtbOYVJqgJ+8BMzXZtYgmcPuNFM6o/XbJQg9Yth0kSExB5sRBvkBg 3D5A== X-Gm-Message-State: AJIora9cXWEpM5C1zy147JrJ52vXZmY16VolGLAHUFfRXGRv0NYBZLb4 AncvD9CIxcsSXjtm+gz4xI+OznXlYPTabSQnLzE2lTX7r6oWVaOBZ73m4MGHoqZlAmPh9Gfo+/9 ALPqEn9ek++HSs5WhPYHP4YQb X-Received: by 2002:a1c:2b05:0:b0:3a0:2ae2:5277 with SMTP id r5-20020a1c2b05000000b003a02ae25277mr32016341wmr.30.1658243704620; Tue, 19 Jul 2022 08:15:04 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ufZw67mDO/HMSiR5dpo2mMh5Dr7OZ3O/vXfLgflU9RixvUu7uhgILPHQ/3jGFAFcB3ZuKGow== X-Received: by 2002:a1c:2b05:0:b0:3a0:2ae2:5277 with SMTP id r5-20020a1c2b05000000b003a02ae25277mr32016321wmr.30.1658243704438; Tue, 19 Jul 2022 08:15:04 -0700 (PDT) Received: from vschneid.remote.csb ([185.11.37.247]) by smtp.gmail.com with ESMTPSA id bg10-20020a05600c3c8a00b003a0323463absm23061621wmb.45.2022.07.19.08.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 08:15:03 -0700 (PDT) From: Valentin Schneider To: "Jason A. Donenfeld" Cc: Kalle Valo , Herbert Xu , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, Gregory Erwin , Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgense?= =?utf-8?Q?n?= , Rui Salvaterra , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Christian Brauner , linux-crypto@vger.kernel.org Subject: Re: [PATCH v8] ath9k: let sleep be interrupted when unregistering hwrng In-Reply-To: References: <20220629114240.946411-1-Jason@zx2c4.com> <87v8s8ubws.fsf@kernel.org> Date: Tue, 19 Jul 2022 16:15:02 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/22 13:53, Jason A. Donenfeld wrote: > Hi Valentin, > > On 7/11/22, Valentin Schneider wrote: >> Thanks for the Cc. >> >> I'm not hot on the export of wake_up_state(), IMO any wakeup with >> !(state & TASK_NORMAL) should be reserved to kernel internals. Now, here >> IIUC the problem is that the patch uses an inline invoking >> >> wake_up_state(p, TASK_INTERRUPTIBLE) >> >> so this isn't playing with any 'exotic' task state, thus it shouldn't >> actually need the export. >> >> I've been trying to figure out if this could work with just a >> wake_up_process(), but the sleeping pattern here is not very conforming >> (cf. 'wait loop' pattern in sched/core.c), AFAICT the signal is used to >> circumvent that :/ > > I don't intend to work on this patch more. If you'd like to ack the > trivial scheduler change (adding EXPORT_SYMBOL), that'd help, and then > this can move forward as planned. Otherwise, if you have particular > opinions about this patch that you want to happen, feel free to pick > up the patch and send your own revisions (though I don't intend to do > further review). Alternatively, I'll just send a patch to remove the > driver entirely. Hopefully you do find this ack-able, though. > I'm not for a blanket wake_up_state() export, however if we *really* need it then I suppose we could have a wake_up_process_interruptible() exported and used by __set_notify_signal().