From: Valentin Schneider <vschneid@redhat.com>
To: Shrikanth Hegde <sshegde@linux.ibm.com>,
mingo@kernel.org, peterz@infradead.org,
vincent.guittot@linaro.org, linux-kernel@vger.kernel.org
Cc: sshegde@linux.ibm.com, kprateek.nayak@amd.com,
juri.lelli@redhat.com, dietmar.eggemann@arm.com, tj@kernel.org,
rostedt@goodmis.org, mgorman@suse.de, bsegall@google.com,
arighi@nvidia.com, pauld@redhat.com
Subject: Re: [PATCH v4 3/4] sched/fair: Add sched_smt_active check for fastpaths
Date: Tue, 19 May 2026 11:25:25 +0200 [thread overview]
Message-ID: <xhsmhmrxv21kq.mognet@vschneid-thinkpadt14sgen2i.remote.csb> (raw)
In-Reply-To: <20260515172456.542799-4-sshegde@linux.ibm.com>
On 15/05/26 22:54, Shrikanth Hegde wrote:
> For fastpaths such as wakeup and load balance even minimal code additions
> can add up. is_core_idle is accessed during load balance.
>
> Other callsites of is_core_idle make sched_smt_active() check first.
> Make the same check in should_we_balance.
>
> Rest of access to cpu_smt_mask isn't in fastpath.
>
> Note: Remove the stale comment above is_core_idle. Enqueue methods
> of fair aren't close to it anymore.
>
> Suggested-by: K Prateek Nayak <kprateek.nayak@amd.com>
> Signed-off-by: Shrikanth Hegde <sshegde@linux.ibm.com>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
next prev parent reply other threads:[~2026-05-19 9:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 17:24 [PATCH v4 0/4] sched: Simplify CONFIG_SCHED_SMT ifdef usage Shrikanth Hegde
2026-05-15 17:24 ` [PATCH v4 1/4] topology: Introduce cpu_smt_mask for CONFIG_SCHED_SMT=n Shrikanth Hegde
2026-05-20 8:34 ` [tip: sched/core] " tip-bot2 for Shrikanth Hegde
2026-05-15 17:24 ` [PATCH v4 2/4] sched: Simplify ifdeffery around cpu_smt_mask Shrikanth Hegde
2026-05-20 8:34 ` [tip: sched/core] " tip-bot2 for Shrikanth Hegde
2026-05-15 17:24 ` [PATCH v4 3/4] sched/fair: Add sched_smt_active check for fastpaths Shrikanth Hegde
2026-05-19 9:25 ` Valentin Schneider [this message]
2026-05-20 8:34 ` [tip: sched/core] " tip-bot2 for Shrikanth Hegde
2026-05-15 17:24 ` [PATCH v4 4/4] sched: Unify SMT active check via sched_smt_active() Shrikanth Hegde
2026-05-20 8:34 ` [tip: sched/core] " tip-bot2 for Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xhsmhmrxv21kq.mognet@vschneid-thinkpadt14sgen2i.remote.csb \
--to=vschneid@redhat.com \
--cc=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sshegde@linux.ibm.com \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®