From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4752B23EA81 for ; Fri, 9 Jan 2026 09:15:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767950123; cv=none; b=tzs7tlCGejfncvsLz2EppkO3dhq3BV+5Qsj8cGskl6OhE8b1Kws6dqvN6jy3VnSXW//2+P2dyFOOxVKqw0Qv268vyGmS31EsHXUTvcboRpQU1edye/XQR/Cm80it4rAU8/WaxPuEg1yQqfB+/370KPhpg7BswG/tz82MqP1erlA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767950123; c=relaxed/simple; bh=OEZ9ClI92b+1ETEy/Xw65u5GKAXEEZNR5WiTVxu55Ps=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=N3mCi3OSolHHS5nv4Bij00oGsc/lF61U3cRXpsK71aO/Iqii7rvzVOxBkZZkn5So0hx0cCpbjap79qSvBc+qXkSE8e6VAvUfuQLzzl5306F+UWjBSJkL/x/gFucVR563u0/AlnfEXftW38ZeVEPXe2UwD6kwsRCbMZs7bGKSmHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bl+52Wtx; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=RZATTwDw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bl+52Wtx"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="RZATTwDw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767950121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7vBj8YT4yOW0RxeERIyPH7BT1O+L6/ulsl63CLthYMA=; b=bl+52Wtx1Yt2LHwjXataygiBVMpa6RW/WCRB9jsvKLG2IRtOB8ASo9MgyhHanilm9KQ3vh nXNJ03NdHkSiRNzVMoTimgQiQMDv3vWdJJT0q6fHcuuBQqF6FyQxQEPUaJalvEN4Hl2P22 UMvORUTIrN5KbhFWE2DA5j7AZT8ByrY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-2IRODTc2O3-oizNRjtdpuw-1; Fri, 09 Jan 2026 04:15:20 -0500 X-MC-Unique: 2IRODTc2O3-oizNRjtdpuw-1 X-Mimecast-MFC-AGG-ID: 2IRODTc2O3-oizNRjtdpuw_1767950119 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-477b8a667bcso44836455e9.2 for ; Fri, 09 Jan 2026 01:15:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767950119; x=1768554919; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=7vBj8YT4yOW0RxeERIyPH7BT1O+L6/ulsl63CLthYMA=; b=RZATTwDwqUWsCfxLTM+muLdvpI9Dl130dm8RGXq5bJd2V+Ka+CWKDl5XJD5K7NtXOZ mBmSbdiDcyvyGQoKIOgfspqkOSvCEYqkmPhP2kvUEZ+wNaDNbLp8yGpSA62DkKtQHTDf /cx61Ot5GtNudyibDX8gLNK2EXF6tGEPM40eXAp3Dt0HaEAQMzx2zYVbDQHahObC+hYS 1tVe/Hrm9g00Y9PkDoDWLR8Al2OfHJHxsKpt2FBgR5Ln4+3ggAuETQ0sqhtTqzUq0ayj ZI2d5fTbP16kPXjtELoA+hzdVtxt0bSiRbQdz0FHySwDsrrb10vcXo6RoDbGbvyUCFE7 G5ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767950119; x=1768554919; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7vBj8YT4yOW0RxeERIyPH7BT1O+L6/ulsl63CLthYMA=; b=BdR6AT24hx32XTi0UM/gAXSSO/9KRJ/Wq31bLu6P++bB9inSRyQsXY2LgrYoMX6HH6 rdNJZD5PPKsD9BgutuxOvVJ/XGUBCXbYNGvebifF8v+1SUaUEb2qr45InjOsT0aO9A0u nYdDUlHMJwxV3Kq9kfIpLRE4RSi5zqBj68nacLCZRdMLJG6RH4sXR7PdmvOw54ezlIGb r4QGH5CExjTBtyBI8V2mKBl2Ew6uI3G8x5BaZYozxyEEvuoHt4LG5HqfBEUpY39vuzSz shaKn3uOSIqIbVn0oBqAcFOAta/rsGrTyZSSMaciTLODyqSEoGx+476IakKLoTwgHrt3 aPEg== X-Gm-Message-State: AOJu0YxrZadVm5TycXoRRR9HLueiuFDIabwPBKo82LM65Gy9GTfV+BTn mlyVNqLb72b5oPGlrgoB2BnxVtWkgmufy7vPLHwROA8Caa9kLPLe3F0bK/sRHOo5LlyaxzoPwwj psUloXla2n38zDVY2BWgrYRhtOJ8+0wMPUuI/tYUiYrE+7hxxKrjOYWKMwDgOjuDxBA== X-Gm-Gg: AY/fxX7POiKZ5Rmop9PKr/j63Me+uLYX0XbW6r4UkcCRc+L4lCJK5/qeL8SMt1mSoMZ jRItNIZSE4I5YDFO6Tk7YqjTestoutAPoWFnc/F7UKJZMVrZjzXmD/eMbEtYXlFEkoofWlLxFmX dX4m4LJr41phDxt3zzBLHEv5VEHoOM0iwZasslz5nIBDUChVonLGjyEUXA00OlIl/eclIbFMmMW TS1VYxwiPCQx4++TS2s7EfdZwAYg6ej2Gg3g2s/AIGihwPrSsGBHAytPm6VbE3WAbn+QDkTJ4qU YupklceD86uUZ6H0yVAqLmyAeuRu1N/kWYCbVmn5eLYtUW6OOqrNCvPfKcHl/XmfnhFjRyZulbM b+sGckBeuqhPhIsdrgyHgwAOn2zSSvqbXXei1uOu0D5U8htCDentNSlXqeJ7yPiEAdq6c1fw= X-Received: by 2002:a05:600c:3484:b0:46e:7e22:ff6a with SMTP id 5b1f17b1804b1-47d84b1fd4bmr109303755e9.15.1767950118960; Fri, 09 Jan 2026 01:15:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IFmChIR6DeQ678B1Tp/tH3X/zCejZkZpi6phsTwcz00GzTpIpDnDS693k41e1SXm1fzCMpOxg== X-Received: by 2002:a05:600c:3484:b0:46e:7e22:ff6a with SMTP id 5b1f17b1804b1-47d84b1fd4bmr109303365e9.15.1767950118433; Fri, 09 Jan 2026 01:15:18 -0800 (PST) Received: from vschneid-thinkpadt14sgen2i.remote.csb (213-44-135-146.abo.bbox.fr. [213.44.135.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d8717db51sm57311375e9.11.2026.01.09.01.15.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jan 2026 01:15:18 -0800 (PST) From: Valentin Schneider To: Breno Leitao , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman Cc: linux-kernel@vger.kernel.org, tj@kernel.org, kernel-team@meta.com, Breno Leitao Subject: Re: [PATCH] sched: Fix NULL pointer dereference in sched_mm_cid_fork() In-Reply-To: <20251230-sched-v1-1-dd4b2a21cef4@debian.org> References: <20251230-sched-v1-1-dd4b2a21cef4@debian.org> Date: Fri, 09 Jan 2026 10:15:17 +0100 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 30/12/25 06:34, Breno Leitao wrote: > Function sched_mm_cid_fork() contains a WARN_ON_ONCE() check that > triggers when mm is NULL, but execution continues regardless, leading to > a NULL pointer dereference when attempting to lock &mm->mm_cid.mutex. > > Unable to handle kernel NULL pointer dereference at virtual address 00000000000001e0 > [00000000000001e0] user address but active_mm is swapper > Internal error: Oops: 0000000096000005 [#1] SMP > Modules linked in: > CPU: 9 UID: 0 PID: 1 Comm: swapper/0 Tainted: > pc : __mutex_lock_common > Call trace: > __mutex_lock_common > mutex_lock_nested > sched_mm_cid_fork > sched_mm_cid_after_execve > bprm_execve > > This crash can occur during execve() failure paths where > sched_mm_cid_after_execve() is called with a task that has a NULL mm. > > Fix this by making the function return early if the WARN_ON_ONCE() > condition is true, preventing the NULL pointer dereference. > > Signed-off-by: Breno Leitao > --- > I've inadvertently reproduced this bug by booting the kernel with an > init binary from a different architecture. > > Specifically, I cross-compiled the kernel, but the init binary was built > for an architecture that didn't match the kernel. > > With the applied fix, I now see the following line instead of > experiencing a crash. > > Kernel panic - not syncing: Requested init mybinary failed (error -8) A slightly different fix is on its way, see: https://lore.kernel.org/lkml/20251223215113.639686-1-xiyou.wangcong@gmail.com/