From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55039C54EBE for ; Fri, 13 Jan 2023 16:53:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230184AbjAMQxG (ORCPT ); Fri, 13 Jan 2023 11:53:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229582AbjAMQwf (ORCPT ); Fri, 13 Jan 2023 11:52:35 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 628E48D5DA for ; Fri, 13 Jan 2023 08:49:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673628513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V7kHcZok2JboWt/NUnzQQm3ugGQ47nBsRs2mV8W7iXk=; b=hsabIP8a5QhUBp0dtFcd+4dxJO9NkbYDzRdvVs7Xx165onm/8dF0f8ipcFoKvaRN5mCakF 9f8CCQjQO9TND6Evqm7X5Plxa3pwnHpYUZRvjmuiWESo2VHNpIQ9EaRi+l6ONIfqJpwENE 8XDHt4IRrtD8z2fKWksJo1yTr4m36nE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-591-G419EohtO7mkyPXKvF31xQ-1; Fri, 13 Jan 2023 11:48:32 -0500 X-MC-Unique: G419EohtO7mkyPXKvF31xQ-1 Received: by mail-wr1-f71.google.com with SMTP id b6-20020adfc746000000b002bae2b30112so4332982wrh.13 for ; Fri, 13 Jan 2023 08:48:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V7kHcZok2JboWt/NUnzQQm3ugGQ47nBsRs2mV8W7iXk=; b=4o82xrTUQVkMRqmcYJYYUJ4DmA6GMNVTvO9MXpzs/eq9Cu6dEPE8CrWdSGSu9Qrvk0 ERLy+IDAw79WbL+Oe2UuIh/LUlVsywk/5HSvNc0chGysC+DmUPA8f9QExWncrc+aGIr4 afSwZnlfYvrDCfXZk8DMoql/lOqKSZkftIg4Tiyy9vFiBrVEQ+3ikSStp4Hi7A+g7+xO D5F0/dJaUGGYKu8yzcFf76ONT4ycgwCRXiT8XyA2kusYq6fjwGZITkJBpvhEutun0vrO HrTnt0R84n++aB+yV+b++7ALSqO9cKIIbChU1Fqj32G9CwbvrX/ButUOEike2zjgtYm0 UD6A== X-Gm-Message-State: AFqh2kp9EKkgBhpOgk5bMaQBM8LvifZZXsSBXNSKvmSpCFm/TKN9PTxz jeVvcw5HRhsiUksW2KyCU8XVUCUJjr4Tysays/0jnv2H6u+T4wVba8mt2MBF9XTdxupTPA486yK g/xoNvzc8xNOx5ZLI9J84mzGF X-Received: by 2002:adf:ffcd:0:b0:2bd:db3b:33f5 with SMTP id x13-20020adfffcd000000b002bddb3b33f5mr3973276wrs.3.1673628511640; Fri, 13 Jan 2023 08:48:31 -0800 (PST) X-Google-Smtp-Source: AMrXdXthCwxe2HyQAUqAMUletX/WOKSF5DYScC+JbVyGBLWFTQa9J69Fx8M71m+IJhFtjV5yqkIAdg== X-Received: by 2002:adf:ffcd:0:b0:2bd:db3b:33f5 with SMTP id x13-20020adfffcd000000b002bddb3b33f5mr3973270wrs.3.1673628511448; Fri, 13 Jan 2023 08:48:31 -0800 (PST) Received: from vschneid.remote.csb ([154.57.232.159]) by smtp.gmail.com with ESMTPSA id k2-20020a5d5182000000b00236545edc91sm19630130wrv.76.2023.01.13.08.48.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 08:48:30 -0800 (PST) From: Valentin Schneider To: Tejun Heo , Stephen Rothwell Cc: Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build warning after merge of the workqueues tree In-Reply-To: References: <20230113143102.2e94d74f@canb.auug.org.au> Date: Fri, 13 Jan 2023 16:48:29 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/01/23 16:47, Valentin Schneider wrote: > On 13/01/23 06:31, Tejun Heo wrote: >> On Fri, Jan 13, 2023 at 02:31:02PM +1100, Stephen Rothwell wrote: >>> Hi all, >>> >>> After merging the workqueues tree, today's linux-next build (x86_64 >>> allnoconfig and several others) produced this warning: >>> >>> kernel/workqueue.c:1993:13: warning: 'rebind_worker' defined but not used [-Wunused-function] >>> 1993 | static void rebind_worker(struct worker *worker, struct worker_pool *pool) >>> | ^~~~~~~~~~~~~ >>> >>> Introduced by commit >>> >>> 793777bc193b ("workqueue: Factorize unbind/rebind_workers() logic") >> >> Valentin, this is caused by rebind_worker() being only used by >> rebind_workers() which is inside CONFIG_SMP. I don't see any other uses of >> rebind_worker(). Just fold it back into rebind_workers()? >> > > Woops! Yes I only did it to keep things aligned with unbind_workers(), let > me resend with that folded back in. Sorry! > Unless you'd prefer a fixup patch on top of those you've already picked up? >> Thanks. >> >> -- >> tejun