From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 662AD30596F for ; Fri, 27 Mar 2026 15:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774626266; cv=none; b=GX6cwV5MqEZmNnvz35PN+f62dTRtWyiKOQ2mheMz2N9buD2RxPqhFTQXYdoCpDragBVAiHKKaoLaIMA3bodRgSZrpDt3HVCdBMVXIGzbKFT1aaOi9/LqOZJsZR32WahXiP55KZYcJCXEKU30EK2HtKola83V/Se5UgldbS0rCOg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774626266; c=relaxed/simple; bh=P39BRN7Sh2CZmlMFqSC6/0b8PlNroAnbQYQ26b/k/Z8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=WdDi8QZi+2EQC3jsOBYvAVqchT5WATsQ3Han5R0Bwi2iHjPDRkZTOd+PejKM553nO74lnswj4/Yw7SUA47z6Y8BoZBrmsHTDV3/gBMxQIe8Y0pUsSVYKI6saiOvtrJU+BHC+cpOqJBkpjD8v6sCMf79sYPrNCnWh5Ow9OJqwrOc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WX6TE85p; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=AG82TW82; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WX6TE85p"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="AG82TW82" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774626264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xo3+FMGXxrujtjtoyKZbBg5+fD0RN0d7dP/Sl3CYs+c=; b=WX6TE85pEi1S2fPiWG83yVIGo6V7p+Tbn0rBs3q9ezPufAdcX8wMb6STiAi3qiklgXUkVL JrdqskVUJC286RwOMav9e2RiQB2A9M4gYR53euHtEdCwwss3So84+D1gZXY00u7v2xN3wB eP8KSDFLa4sSjI+wUHtO2RueWRQY3S4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-361-NeELAh40PeCmPynaNfHlTQ-1; Fri, 27 Mar 2026 11:44:22 -0400 X-MC-Unique: NeELAh40PeCmPynaNfHlTQ-1 X-Mimecast-MFC-AGG-ID: NeELAh40PeCmPynaNfHlTQ_1774626262 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48544725bdeso31980495e9.2 for ; Fri, 27 Mar 2026 08:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774626261; x=1775231061; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=xo3+FMGXxrujtjtoyKZbBg5+fD0RN0d7dP/Sl3CYs+c=; b=AG82TW82Rvol1Jn0MwxFQiKr5GZZfBgp1H7bLT2pOJowX6w1b+QozXf1prC0rby9g6 0z7GZXovg0Yxr/z3og7b+WSvvLyBFoxFJppHegPuM7jdLxXpuN54zfH6PbE/Zjequ4Kn N4AnU+rHjKjcGrNobTba5wDYv+egGMdK2d2b4Ip+33uMqa2fWy6MqCXOHCtDgkZ/sdgB ZfM/a6iAU27MRwfwz/5wc+cDfJkncs1GY0eydbLywwXywePS9lT70zJJez7IAunTdHKE Y0yhU7Zx23AHuupM36Pjd7759TlYuWzGpyBHUxBnOE4f39nStWwlJuZ2x3EnSLAhGHFz MdsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774626261; x=1775231061; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xo3+FMGXxrujtjtoyKZbBg5+fD0RN0d7dP/Sl3CYs+c=; b=ScouMu9BiKR+8kVM/9GAN+PJzpNMy3+2tYhhf30goK//BDeTHgB5jf3gALklxNaFUx Iw+Z979E0WSLBl3I6wRRtp7HO1yM2UYqQVrrFZGSC/69N5VdnL2Z3iCCI0WtU2t3kEKG 6AH0g0ntGf7rhnhGMPhWIGtgyFoHfR7OW2Z1qsUIMQTbPqrRX99uC6n0fLSdpHVCQRN5 hPyuaBf+ZKqcBK/g9T5mebfJG++rXniN3ffYMne6yQy4S6DqQpGbylRVe6hSP6EcUVRn LlOo/ZjWhHhqejBVqrwWWCr+nSQAihDnB/NWnnjphrtg9Yd5+Fz4Ps0PDdAP3Qv0CBeB uRtw== X-Forwarded-Encrypted: i=1; AJvYcCXhstik9q2hCiSMRaSupoR5/TVngpMPhEfLwfTNPjorVkDVCzj7vA/IIrwOWgcXYLR/o/C/MuDWTPvOBw0=@vger.kernel.org X-Gm-Message-State: AOJu0YxSVoC5lBeytxR+Ihhp164XcAxY1Hshpy7EfWR2WQSFEB4W5udq BCG1WkcoQble6QpLXc6JsSkHoFuggF82dm1//9vTXQOS+p0BNnwRnXAp9HV+capj/4TNEQGBIJO qfXmCJE8OY0MF396dKA8Be/Zi8kAZz7mrya403iI6kQEwOGZ4RwUfAO/r0fgGTO7l0g== X-Gm-Gg: ATEYQzwksPJRLeg5Zhuir0EyK+a5twWPtVYMUpS1pQypzHmGgLlcU8JDBVKv1dBGXpu 9rkce20PVX3MCPCWwyt0Ek3f0X0AE/5c8VVCBbwHUikrAOli8WY3Xd7JWqlILqijfgT4GXGHuv3 aWE4WZL/ERLXT5zZZQwt6lGKMaPzy33zMmqlPQJtfmaxE92TIXSmoO1jiS/Cj+PNW5NULtKs1Rb ltaWIUmxJKECyRseofLpW81teCOo4tm1suPQegXdY0wWSgv3MF4e7ednk0c30LU9T0jf7y28NGe UuuVdGoSSuzoHUjCEpiUpAF3BdA3qGLU7iun4UgCbEbeheqwCfrVpL123gkiMpEM8yWJzcEgd0v 3QyyY08x8S9mJU6aF4omlLHl/UEJ9j1f/Rx9kM1nSixp4X14BW9DfBHDcMyK53dFyKVFq183hN8 uuWjM86JQ= X-Received: by 2002:a05:600d:d:b0:485:40a4:364 with SMTP id 5b1f17b1804b1-48727ecf3edmr41347125e9.26.1774626261528; Fri, 27 Mar 2026 08:44:21 -0700 (PDT) X-Received: by 2002:a05:600d:d:b0:485:40a4:364 with SMTP id 5b1f17b1804b1-48727ecf3edmr41346615e9.26.1774626261105; Fri, 27 Mar 2026 08:44:21 -0700 (PDT) Received: from vschneid-thinkpadt14sgen2i.remote.csb (213-44-135-146.abo.bbox.fr. [213.44.135.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722c9f0afsm178875865e9.10.2026.03.27.08.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2026 08:44:20 -0700 (PDT) From: Valentin Schneider To: Christian Loehle , arighi@nvidia.com Cc: peterz@infradead.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, valentin.schneider@arm.com, mingo@redhat.com, rostedt@goodmis.org, segall@google.com, mgorman@suse.de, catalin.marinas@arm.com, will@kernel.org, sudeep.holla@arm.com, rafael@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, juri.lelli@redhat.com, kobak@nvidia.com, fabecassis@nvidia.com, Christian Loehle Subject: Re: [PATCH 3/3] arm64/sched: Enable CPPC-based asympacking In-Reply-To: <20260325181314.3875909-4-christian.loehle@arm.com> References: <20260325181314.3875909-1-christian.loehle@arm.com> <20260325181314.3875909-4-christian.loehle@arm.com> Date: Fri, 27 Mar 2026 16:44:19 +0100 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 25/03/26 18:13, Christian Loehle wrote: > @@ -1753,7 +1760,7 @@ static inline int topology_arch_sched_asym_flags(void) > #ifdef CONFIG_SCHED_SMT > int cpu_smt_flags(void) > { > - return SD_SHARE_CPUCAPACITY | SD_SHARE_LLC; > + return SD_SHARE_CPUCAPACITY | SD_SHARE_LLC | arch_sched_asym_flags(); > } > > const struct cpumask *tl_smt_mask(struct sched_domain_topology_level *tl, int cpu) > @@ -1765,7 +1772,7 @@ const struct cpumask *tl_smt_mask(struct sched_domain_topology_level *tl, int cp > #ifdef CONFIG_SCHED_CLUSTER > int cpu_cluster_flags(void) > { > - return SD_CLUSTER | SD_SHARE_LLC; > + return SD_CLUSTER | SD_SHARE_LLC | arch_sched_asym_flags(); > } > > const struct cpumask *tl_cls_mask(struct sched_domain_topology_level *tl, int cpu) > @@ -1777,7 +1784,7 @@ const struct cpumask *tl_cls_mask(struct sched_domain_topology_level *tl, int cp > #ifdef CONFIG_SCHED_MC > int cpu_core_flags(void) > { > - return SD_SHARE_LLC; > + return SD_SHARE_LLC | arch_sched_asym_flags(); > } > So while the binning problem applies to more than one architecture, I'm not sure we want this to be generally applied to all topology levels. This is /technically/ not a problem since even if a topology level has SD_ASYM_PACKING, all CPUs at that level can have the same priority, but in that case it's a bit wasteful. I don't have any better ideas ATM to keep this arch-specific via set_sched_topology(), like how x86 and powerpc handle asym packing.