mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Thelen <gthelen@google.com>
To: Natanael Copa <ncopa@alpinelinux.org>, bpf@vger.kernel.org
Cc: Natanael Copa <ncopa@alpinelinux.org>,
	stable@vger.kernel.org,  Viktor Malik <vmalik@redhat.com>,
	Daniel Xu <dxu@dxuuu.xyz>, Alexei Starovoitov <ast@kernel.org>,
	 Nick Desaulniers <ndesaulniers@google.com>,
	Andrii Nakryiko <andrii@kernel.org>,
	 linux-kernel@vger.kernel.org,
	Khazhy Kumykov <khazhy@chromium.org>,
	 Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
Subject: Re: [PATCH] tools/resolve_btfids: fix build with musl libc
Date: Thu, 28 Mar 2024 09:18:52 -0700	[thread overview]
Message-ID: <xr93zfuifhxv.fsf@gthelen-cloudtop.c.googlers.com> (raw)
In-Reply-To: <20240328110103.28734-1-ncopa@alpinelinux.org>

Natanael Copa <ncopa@alpinelinux.org> wrote:

> Include the header that defines u32.

> Fixes: 9707ac4fe2f5 ("tools/resolve_btfids: Refactor set sorting with  
> types from btf_ids.h")
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218647

Tested-by: Greg Thelen <gthelen@google.com>

> Cc: stable@vger.kernel.org
> Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
> ---
> This fixes build of 6.6.23 and 6.1.83 kernels for Alpine Linux, which
> uses musl libc. I assume that GNU libc indirecly pulls in linux/types.h.

>   tools/include/linux/btf_ids.h | 2 ++
>   1 file changed, 2 insertions(+)

> diff --git a/tools/include/linux/btf_ids.h b/tools/include/linux/btf_ids.h
> index 72535f00572f..72ea363d434d 100644
> --- a/tools/include/linux/btf_ids.h
> +++ b/tools/include/linux/btf_ids.h
> @@ -3,6 +3,8 @@
>   #ifndef _LINUX_BTF_IDS_H
>   #define _LINUX_BTF_IDS_H

> +#include <linux/types.h> /* for u32 */
> +
>   struct btf_id_set {
>   	u32 cnt;
>   	u32 ids[];

  reply	other threads:[~2024-03-28 16:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28 10:59 Natanael Copa
2024-03-28 16:18 ` Greg Thelen [this message]
2024-03-29  1:59   ` Alexei Starovoitov
2024-03-29  2:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xr93zfuifhxv.fsf@gthelen-cloudtop.c.googlers.com \
    --to=gthelen@google.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=dmitrii.bundin.a@gmail.com \
    --cc=dxu@dxuuu.xyz \
    --cc=khazhy@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncopa@alpinelinux.org \
    --cc=ndesaulniers@google.com \
    --cc=stable@vger.kernel.org \
    --cc=vmalik@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®