From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Shrikanth Hegde <sshegde@linux.ibm.com>,
maddy@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
chzigotzky@xenosoft.de
Cc: sshegde@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, linux-kernel@vger.kernel.org,
msuchanek@suse.de, harshpb@linux.ibm.com, gautam@linux.ibm.com,
amachhiw@linux.ibm.com, venkat88@linux.ibm.com,
nnmlinux@linux.ibm.com, mkchauras@gmail.com
Subject: Re: [PATCH v4 1/3] PPC32: Fix hard_irq_disable to follow tracing and lockdep state
Date: Tue, 17 Nov 2026 18:58:41 +0530 [thread overview]
Message-ID: <y0ar7fjq.ritesh.list@gmail.com> (raw)
In-Reply-To: <20261117131612.707038-2-sshegde@linux.ibm.com>
Shrikanth Hegde <sshegde@linux.ibm.com> writes:
> On PPC32, the code for hard_irq_disable has diverged and it doesn't
> do lockdep/tracing anymore, leading to use of both local_irq_disable
> and hard_irq_disable on PPC32 to overcome those.
>
> That is un-necessary, instead simply calling local_irq_disable is
> enough. It disables EE bit and does lockdep tracking.
>
> Subsequent patch uses this API in KVM code to avoid the warnings.
> Wider use of it is possible, but it will be taken subsequently.
>
> Fixes: 5d38902c4838 ("powerpc: Add irqtrace support for 32-bit powerpc")
> Suggested-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> Signed-off-by: Shrikanth Hegde <sshegde@linux.ibm.com>
> ---
> PS: Fixes tag is based on the historical analysis done by Ritesh.
> I haven't got a chance to delve deep into it. Note that it is old
> commit and lot of code interleave would have happened since
> including local_irq_disable at some would have added proper
> lockdep support.
>
Yes, not sure whether we really want this this fix to go back to that
old change?
Maybe we can add CC: stable and keep the minimum kernel version to it,
so that it gets applied >= vX.Y+ sort of. Instead of stable backports
picking this change and taking it all the way to a very a old kernel
release - which in my opinion is not worth it. Thoughts?
Do we know from when we started hitting this problem? Should this be
after we merge generic entry/exit? Or was there any previous kernel
version too, where we were hitting this?
> arch/powerpc/include/asm/hw_irq.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
BTW, thanks for taking it forward.
The change looks good to me. So, please Feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
However, note that we should still get the stable tag / fixes thing
sorted, for stable backports to do it's right thing.
next prev parent reply other threads:[~2026-11-17 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 13:16 [PATCH v4 0/3] KVM: PPC: BookE: Fix boot hang on preemptible kernels Shrikanth Hegde
2026-11-17 13:16 ` [PATCH v4 1/3] PPC32: Fix hard_irq_disable to follow tracing and lockdep state Shrikanth Hegde
2026-11-17 13:28 ` Ritesh Harjani [this message]
2026-11-17 15:31 ` Shrikanth Hegde
2026-11-17 13:16 ` [PATCH v4 2/3] KVM: PPC: BookE: Load FP and Altivec before enabling the interrupts Shrikanth Hegde
2026-11-17 13:16 ` [PATCH v4 3/3] KVM: PPC: Hard disable interrupts before guest entry Shrikanth Hegde
2026-11-17 13:41 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y0ar7fjq.ritesh.list@gmail.com \
--to=ritesh.list@gmail.com \
--cc=amachhiw@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=chzigotzky@xenosoft.de \
--cc=gautam@linux.ibm.com \
--cc=harshpb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mkchauras@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.de \
--cc=nnmlinux@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=sshegde@linux.ibm.com \
--cc=venkat88@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®