From: fche@redhat.com (Frank Ch. Eigler)
To: Arjan van de Ven <arjan@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
lenb@kernel.org
Subject: Re: PATCH] ftrace: Add a C/P state tracer to help power optimization
Date: Mon, 27 Oct 2008 15:47:30 -0400 [thread overview]
Message-ID: <y0m3aihx1kd.fsf@ton.toronto.redhat.com> (raw)
In-Reply-To: <20081027110522.6cb7b142@infradead.org> (Arjan van de Ven's message of "Mon, 27 Oct 2008 11:05:22 -0700")
Arjan van de Ven <arjan@infradead.org> writes:
> [...]
> --- a/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
> +++ b/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
> [...]
> @@ -427,6 +429,8 @@ static int acpi_cpufreq_target(struct cpufreq_policy *policy,
> }
> }
>
> + trace_power_mark(&it, POWER_PSTATE, next_perf_state);
> +
> switch (data->cpu_feature) {
> case SYSTEM_INTEL_MSR_CAPABLE:
> cmd.type = SYSTEM_INTEL_MSR_CAPABLE;
> [...]
Is there some reason that this doesn't use tracepoints instead
of such a single-backend hook?
- FChE
next prev parent reply other threads:[~2008-10-27 19:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 17:26 Arjan van de Ven
2008-10-06 20:46 ` Andi Kleen
2008-10-06 20:57 ` Arjan van de Ven
2008-10-06 21:19 ` Andi Kleen
2008-10-06 21:21 ` Arjan van de Ven
2008-10-06 21:34 ` Andi Kleen
2008-10-07 10:39 ` Steven Rostedt
2008-10-27 15:59 ` Ingo Molnar
2008-10-27 16:05 ` Steven Rostedt
2008-10-27 16:21 ` Alan Cox
2008-10-27 17:16 ` Steven Rostedt
2008-10-27 18:05 ` Arjan van de Ven
2008-10-27 19:47 ` Frank Ch. Eigler [this message]
2008-10-27 20:13 ` Steven Rostedt
2008-10-27 21:06 ` Arjan van de Ven
2008-10-28 10:04 ` Ingo Molnar
2009-02-10 20:57 ` Jason Baron
2009-02-10 21:26 ` Frederic Weisbecker
2009-02-11 9:30 ` Ingo Molnar
2009-02-11 18:57 ` Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=y0m3aihx1kd.fsf@ton.toronto.redhat.com \
--to=fche@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@infradead.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®