mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: fche@redhat.com (Frank Ch. Eigler)
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	nagar@watson.ibm.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Optimize struct task_delay_info
Date: 12 Jul 2007 14:21:17 -0400	[thread overview]
Message-ID: <y0mzm21eb4y.fsf@ton.toronto.redhat.com> (raw)
In-Reply-To: <1184229443.3068.55.camel@ymzhang>

"Zhang, Yanmin" <yanmin_zhang@linux.intel.com> writes:

> [...]
> > > 2) Delete lock. [..]
> > > In addition, the result is for performance data collection, so it's
> > > unnecessary to add such lock.
> > Not sure that's a good idea. People expect their performance counts
> > to be accurate too. [...]
> [...]
> 2) If the reader could get the correct data when the process updates
> the data. It might be an issue. But the issue is not
> important. Mostly, the application tool reads the data in an
> interval.

Can you elaborate on that some more?  Is it OK for the sample
monitoring program to return inconsistent data sometimes?  Is there
reason to believe that this sample user-space program will remain the
sole consumer of this data?  Might a seqlock be appropriate here?

- FChE

  reply	other threads:[~2007-07-12 18:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-11  7:13 Zhang, Yanmin
2007-07-11 11:46 ` Balbir Singh
2007-07-18  4:30   ` Zhang, Yanmin
2007-07-23  1:08     ` Zhang, Yanmin
2007-07-11 12:27 ` Andi Kleen
2007-07-12  8:37   ` Zhang, Yanmin
2007-07-12 18:21     ` Frank Ch. Eigler [this message]
2007-07-13  1:52       ` Zhang, Yanmin
2007-07-23  5:14 ` Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=y0mzm21eb4y.fsf@ton.toronto.redhat.com \
    --to=fche@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nagar@watson.ibm.com \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®