mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xianghua Xiao <xiaoxianghua@gmail.com>
To: Phil Carmody <ext-phil.2.carmody@nokia.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	john stultz <johnstul@us.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.33.3-rt16 Oops caused by umount
Date: Thu, 29 Apr 2010 10:52:45 -0500	[thread overview]
Message-ID: <y2xe6bf505b1004290852xa079969k3316c5bb7233de13@mail.gmail.com> (raw)
In-Reply-To: <20100429151555.GM17639@pcarmody-desktop>

On Thu, Apr 29, 2010 at 10:15 AM, Phil Carmody
<ext-phil.2.carmody@nokia.com> wrote:
> On 28/04/10 19:54 +0200, ext Xianghua Xiao wrote:
>> On Wed, Apr 28, 2010 at 11:34 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> ...
>> Thomas,
>> I patched it and re-run it however did not find any condition from
>> your patch had a hit.
>> In your patch I changed :
>>
>> if (!file->f_path) {
>> to
>> if(!(&(file->f_path))){
>> Otherwise it won't compile as f_path is a not a pointer.
>
> That check is completely bogus. The address of _anything_ (whose address
> can be taken) is _always_ non-null.
>
> Phil
>

Thomas,

I confirm that 2.6.33.3-rt15 worked fine, reboot/umount will not oops.

Thanks,
Xianghua

  parent reply	other threads:[~2010-04-30 16:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-27 18:44 Xianghua Xiao
2010-04-27 18:56 ` Thomas Gleixner
2010-04-27 20:23   ` john stultz
2010-04-27 20:30     ` john stultz
2010-04-27 20:54       ` Xianghua Xiao
2010-04-27 22:08         ` 2.6.33.3-rt16 - not reaching login Uwaysi Bin Kareem
2010-04-28  6:01         ` 2.6.33.3-rt16 Oops caused by umount john stultz
2010-04-28 15:21           ` Xianghua Xiao
2010-04-28 16:34             ` Thomas Gleixner
2010-04-28 17:54               ` Xianghua Xiao
2010-04-28 19:38                 ` Thomas Gleixner
2010-04-28 20:06                   ` Xianghua Xiao
2010-04-28 20:22                     ` Thomas Gleixner
2010-04-28 21:22                       ` Xianghua Xiao
2010-04-28 21:46                         ` Thomas Gleixner
2010-04-28 23:33                           ` Xianghua Xiao
2010-04-29 12:22                             ` Thomas Gleixner
     [not found]                 ` <20100429151555.GM17639@pcarmody-desktop>
2010-04-29 15:52                   ` Xianghua Xiao [this message]
2010-04-30 10:02                     ` Thomas Gleixner
2010-04-30 14:04                       ` Xianghua Xiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=y2xe6bf505b1004290852xa079969k3316c5bb7233de13@mail.gmail.com \
    --to=xiaoxianghua@gmail.com \
    --cc=ext-phil.2.carmody@nokia.com \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®