From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757316Ab0ECHGV (ORCPT ); Mon, 3 May 2010 03:06:21 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:63510 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753223Ab0ECHGU convert rfc822-to-8bit (ORCPT ); Mon, 3 May 2010 03:06:20 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=GYbfbXeQEiQXTIFoaqa24psuI+2NU7MmczJMQEHSp9iIX75f5cLVRd/DnA/ldMae0J c+MtMed+WAgo24tZpyDI3jZO0YwSaXA0HuGsqQPZlFnBO3PpjY31AltMhJ4h3ViEdR8E BIndtsvQXLhKW4VtNvUvVRBftrShBSvEIQdzk= MIME-Version: 1.0 In-Reply-To: <4BDE67DA.4080004@redhat.com> References: <1272818776-7729-1-git-send-email-xiaosuo@gmail.com> <4BDDB6E9.4060703@redhat.com> <201005030915.FCD09385.FFHVOMJtSLOFQO@I-love.SAKURA.ne.jp> <4BDE67DA.4080004@redhat.com> From: Changli Gao Date: Mon, 3 May 2010 15:05:59 +0800 Message-ID: Subject: Re: [PATCH] fs: use kmalloc() to allocate fdmem if possible To: Avi Kivity Cc: Tetsuo Handa , jslaby@suse.cz, akpm@linux-foundation.org, paulmck@linux.vnet.ibm.com, adobriyan@gmail.com, mingo@elte.hu, peterz@infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 3, 2010 at 2:06 PM, Avi Kivity wrote: > > My point is, vmalloc() and vfree should do this, not their callers: > > vmalloc(size): >    if (size <= PAGE_SIZE) >        return kmalloc(size, GFP_KERNEL); >    ... > > vfree(p): >    if (!is_vmalloc_addr(p) { >        kfree(p); >        return; >    } >    ... I think we should not change vmalloc/vfree, and you can invent new memory APIs, such as malloc()/free(). -- Regards， Changli Gao(xiaosuo@gmail.com)