From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750769AbWDUXje (ORCPT ); Fri, 21 Apr 2006 19:39:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750770AbWDUXje (ORCPT ); Fri, 21 Apr 2006 19:39:34 -0400 Received: from mraos.ra.phy.cam.ac.uk ([131.111.48.8]:14767 "EHLO mraos.ra.phy.cam.ac.uk") by vger.kernel.org with ESMTP id S1750769AbWDUXjd (ORCPT ); Fri, 21 Apr 2006 19:39:33 -0400 To: Hugh Dickins Cc: Pavel Machek , Arkadiusz Miskiewicz , Jeff Chua , Jeff Garzik , Matt Mackall , Jens Axboe , Linux Kernel Subject: Re: sata suspend resume ... References: <20060420134713.GA2360@ucw.cz> <20060421163930.GA1648@elf.ucw.cz> From: Chris Ball Date: Sat, 22 Apr 2006 00:39:25 +0100 In-Reply-To: (Hugh Dickins's message of "Fri, 21 Apr 2006 21:44:59 +0100 (BST)") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) XEmacs/21.4 (Social Property, linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org >> On Fri, 21 Apr 2006, Hugh Dickins said: > But you've made me try a bit harder, and the patch below, waiting > for ATA_BUSY to clear, copying a line used in several other places > there, fixes it in a much more satisfactory way than mdelay(2000). > (I checked how long it in fact was waiting, saw various waits > between 0.8s and 1.3s). FWIW, this patch fixes S3 resume for me too. I'm on an Alienware m5500 using sd_mod and ata_piix, and I think your T43p is using AHCI, so it seems that this fixes a libata-wide problem rather than something specific to your hardware. - Chris. -- Chris Ball