From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8097AC4649B for ; Fri, 5 Jul 2019 12:28:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B0E3218D1 for ; Fri, 5 Jul 2019 12:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562329680; bh=dW7+yV8waH31bo5/Ho09eL3LeOtx3l2YmJNVaozgVu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=y1DmZKKBDujhT8MxOJoOS8JeND1NXKFKSHXP+ByInoTBXLhOKf2x+n1CDb75mWYTu rOqvYj/Ei8v6QhdPf1wFspACa8TaquRcmyym9ubhXr6RPyy6P3m6AnNj2jsJ/29gse Z6P5LnKXiMZcfAtBE454TaogWbEMnxjXv7C8Rz3E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728640AbfGEM17 (ORCPT ); Fri, 5 Jul 2019 08:27:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:43832 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbfGEM16 (ORCPT ); Fri, 5 Jul 2019 08:27:58 -0400 Received: from localhost (deibp9eh1--blueice1n7.emea.ibm.com [195.212.29.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05E9421850; Fri, 5 Jul 2019 12:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562329677; bh=dW7+yV8waH31bo5/Ho09eL3LeOtx3l2YmJNVaozgVu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FEUS8cWk+Q6Ul4bM5zwJjUs9QhRMjJIA4f4ZSlDYFAQihmc802L5/PdvVrf0HIKRH yyY7UwOP+7VZheiMqb258FlXlDs0ui7oW4YxuOoNb2kZkoruOLMww1NHymRRWRPu4h A0vTs2Qwn+D37ZAYJ+UgsLW4BQgVGSo1ZGtNxmBo= Date: Fri, 5 Jul 2019 14:27:53 +0200 From: Vasily Gorbik To: Steffen Maier Cc: linux-doc@vger.kernel.org, linux-s390@vger.kernel.org, Mauro Carvalho Chehab , Mauro Carvalho Chehab , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] docs: s390: unify and update s390dbf kdocs at debug.c Message-ID: References: <1562149189-1417-1-git-send-email-maier@linux.ibm.com> <1562149189-1417-3-git-send-email-maier@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1562149189-1417-3-git-send-email-maier@linux.ibm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 03, 2019 at 12:19:48PM +0200, Steffen Maier wrote: > For non-static-inlines, debug.c already had non-compliant function > header docs. So move the pure prototype kdocs of > ("s390: include/asm/debug.h add kerneldoc markups") > from debug.h to debug.c and merge them with the old function docs. > Also, I had the impression that kdoc typically is at the implementation > in the compile unit rather than at the prototype in the header file. > > While at it, update the short kdoc description to distinguish the > different functions. And a few more consistency cleanups. > > Added a new kdoc for debug_set_critical() since debug.h comments it > as part of the API. > > Signed-off-by: Steffen Maier > --- > Documentation/s390/s390dbf.rst | 1 + > arch/s390/include/asm/debug.h | 112 ++++++----------------------------------- > arch/s390/kernel/debug.c | 105 +++++++++++++++++++++++++++++++------- > 3 files changed, 102 insertions(+), 116 deletions(-) > Applied with "permisions->permissions" and couple of whitespaces removed, thanks.