From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755328AbYE2LuQ (ORCPT ); Thu, 29 May 2008 07:50:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751704AbYE2LuB (ORCPT ); Thu, 29 May 2008 07:50:01 -0400 Received: from jaguar.mkp.net ([192.139.46.146]:57565 "EHLO jaguar.mkp.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbYE2LuA (ORCPT ); Thu, 29 May 2008 07:50:00 -0400 To: Alan Cox Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmtimer: Push BKL down into the ioctl handler References: <20080522214244.457da3d7@core> From: Jes Sorensen Date: 29 May 2008 07:49:59 -0400 In-Reply-To: <20080522214244.457da3d7@core> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Alan" == Alan Cox writes: Alan> Switches to unlocked_ioctl read to remove ioctl BKL method. Fix Alan> the unknown ioctl return. Probably a nice easy one to kill off Alan> BKL usage entirely later Alan> Signed-off-by: Alan Cox Looks good to me, I should check whether we can't just kill the lock_kernel() here - I suspect it shouldn't be an issue. Acked-by: Jes Sorensen Cheers, Jes