From: Jes Sorensen <jes@sgi.com>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Andrew Morton <akpm@osdl.org>,
Chandra Seetharaman <sekharan@us.ibm.com>,
Keith Owens <kaos@sgi.com>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/8] Notifier chain update
Date: 19 Jan 2006 04:55:57 -0500 [thread overview]
Message-ID: <yq0r7747d8y.fsf@jaguar.mkp.net> (raw)
In-Reply-To: <20060118214204.GG16285@kvack.org>
>>>>> "Benjamin" == Benjamin LaHaise <bcrl@kvack.org> writes:
Benjamin> On Wed, Jan 18, 2006 at 03:23:20PM -0500, Alan Stern wrote:
>> You can't use RCU protection around code that may sleep. Whether
>> the code remains loaded in the kernel or is part of a removable
>> module doesn't enter into it.
Benjamin> A notifier callee should not be sleeping, if anything it
Benjamin> should be putting its work onto a workqueue and completing
Benjamin> it when it gets scheduled if it has to do something that
Benjamin> blocks.
There are cases where all the notifier client would want to do is
kmalloc(); sum_up_some_data(); copy_to_user(); kfree();
very often in the exit() path - doing that via a workqueue seems
overly complex.
Cheers,
Jes
prev parent reply other threads:[~2006-01-19 9:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-18 16:34 Alan Stern
2006-01-18 18:19 ` Benjamin LaHaise
2006-01-18 20:23 ` Alan Stern
2006-01-18 21:42 ` Benjamin LaHaise
2006-01-18 21:57 ` Alan Stern
2006-01-18 22:00 ` David S. Miller
2006-01-18 22:04 ` Alan Stern
2006-01-18 23:06 ` Alan Cox
2006-01-19 3:33 ` Alan Stern
2006-01-18 22:01 ` Benjamin LaHaise
2006-01-18 22:09 ` Alan Stern
2006-01-18 22:15 ` Benjamin LaHaise
2006-01-19 10:01 ` Jes Sorensen
2006-01-18 22:18 ` David S. Miller
2006-01-18 22:18 ` Benjamin LaHaise
2006-01-18 23:07 ` Alan Cox
2006-01-19 9:55 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq0r7747d8y.fsf@jaguar.mkp.net \
--to=jes@sgi.com \
--cc=akpm@osdl.org \
--cc=bcrl@kvack.org \
--cc=kaos@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sekharan@us.ibm.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®