mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jes Sorensen <jes@trained-monkey.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, Christoph Hellwig <hch@lst.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] updates XFS mutex patch
Date: 29 Dec 2005 06:06:47 -0500	[thread overview]
Message-ID: <yq0vex8tb5k.fsf@jaguar.mkp.net> (raw)
In-Reply-To: <1135854222.2935.15.camel@laptopd505.fenrus.org>

>>>>> "Arjan" == Arjan van de Ven <arjan@infradead.org> writes:

Arjan> On Thu, 2005-12-29 at 05:59 -0500, Jes Sorensen wrote:
>> + +#define xfs_mutex_init(lock, type, name) mutex_init(lock)
>> +#define xfs_mutex_lock(lock, type) mutex_lock(lock) +#define
>> mutex_destroy(lock) do{}while(0)

Arjan> why not just change all mutex_init users to only pass lock?
Arjan> (same for the others) eg why add another abstraction instead of
Arjan> fixing the caller?

I have no objections to this, however I am not sure if the XFS guys
try to maintain some level of source compatibility. Just trying to
play nicely, but I agree that would be cleaner.

Cheers,
Jes

  reply	other threads:[~2005-12-29 11:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-29 10:59 Jes Sorensen
2005-12-29 11:03 ` Arjan van de Ven
2005-12-29 11:06   ` Jes Sorensen [this message]
2005-12-29 11:07 ` Ingo Molnar
2005-12-29 14:48 ` Christoph Hellwig
2005-12-29 16:38   ` Jes Sorensen
2005-12-29 16:58   ` Ingo Molnar
2005-12-29 17:11     ` Christoph Hellwig
2005-12-29 19:41       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq0vex8tb5k.fsf@jaguar.mkp.net \
    --to=jes@trained-monkey.org \
    --cc=arjan@infradead.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®