From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Keith Busch <kbusch@kernel.org>
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org, axboe@kernel.dk, hch@lst.de,
martin.petersen@oracle.com, colyli@suse.de
Subject: Re: [PATCHv2 6/7] block: add pi for nvme enhanced integrity
Date: Tue, 01 Feb 2022 23:35:35 -0500 [thread overview]
Message-ID: <yq11r0l6gd7.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20220201190128.3075065-7-kbusch@kernel.org> (Keith Busch's message of "Tue, 1 Feb 2022 11:01:27 -0800")
Keith,
This all looks pretty good to me. Only nit I have is:
> +static blk_status_t nvme_pi_type1_verify_crc(struct blk_integrity_iter *iter)
> +{
> + return nvme_crc64_verify(iter, T10_PI_TYPE1_PROTECTION);
> +}
> +
> +static blk_status_t nvme_pi_type1_generate_crc(struct blk_integrity_iter *iter)
> +{
> + return nvme_crc64_generate(iter, T10_PI_TYPE1_PROTECTION);
> +}
Since we will definitely need to support the CRC32C variants, the
nvme_pi_type1_ prefix is a bit too generic. Wish we had gone with Type 4
and 5 like I originally proposed in SCSI. Not a big fan of this "almost
exactly like T10 Type 1 except for all these differences" situation that
NVMe ended up with.
Anyway. So I think the NVMe-specific format helpers need to at the very
least capture that they are for the CRC64 case.
Other than that it looks OK.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-02-02 4:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 19:01 [PATCHv2 0/7] 64-bit data integrity field support Keith Busch
2022-02-01 19:01 ` [PATCHv2 1/7] block: support pi with extended metadata Keith Busch
2022-02-02 4:38 ` Martin K. Petersen
2022-02-02 13:11 ` Hannes Reinecke
2022-02-01 19:01 ` [PATCHv2 2/7] nvme: allow integrity on extended metadata formats Keith Busch
2022-02-02 4:39 ` Martin K. Petersen
2022-02-02 13:12 ` Hannes Reinecke
2022-02-01 19:01 ` [PATCHv2 3/7] lib: add rocksoft model crc64 Keith Busch
2022-02-02 4:40 ` Martin K. Petersen
2022-02-02 13:13 ` Hannes Reinecke
2022-02-01 19:01 ` [PATCHv2 4/7] lib: add crc64 tests Keith Busch
2022-02-02 4:42 ` Martin K. Petersen
2022-02-02 13:14 ` Hannes Reinecke
2022-02-01 19:01 ` [PATCHv2 5/7] asm-generic: introduce be48 unaligned accessors Keith Busch
2022-02-02 4:41 ` Martin K. Petersen
2022-02-02 13:15 ` Hannes Reinecke
2022-02-01 19:01 ` [PATCHv2 6/7] block: add pi for nvme enhanced integrity Keith Busch
2022-02-02 4:35 ` Martin K. Petersen [this message]
2022-02-02 13:19 ` Hannes Reinecke
2022-02-02 18:40 ` Bart Van Assche
2022-02-01 19:01 ` [PATCHv2 7/7] nvme: add support for enhanced metadata Keith Busch
2022-02-02 4:48 ` Martin K. Petersen
2022-02-02 13:28 ` Hannes Reinecke
2022-02-02 15:41 ` Keith Busch
2022-02-02 15:47 ` Martin K. Petersen
2022-02-02 16:38 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11r0l6gd7.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome