From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935989AbdEXCCq (ORCPT <rfc822;w@1wt.eu>);
        Tue, 23 May 2017 22:02:46 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:35528 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751620AbdEXCCn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 23 May 2017 22:02:43 -0400
To: Joe Perches <joe@perches.com>
Cc: Nicolas Iooss <nicolas.iooss_linux@m4x.org>,
        GOTO Masanori <gotom@debian.or.jp>,
        YOKOTA Hiroshi <yokota@netlab.is.tsukuba.ac.jp>,
        "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] scsi: nsp32: add __printf attribute to logging functions
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
References: <20170520111628.24787-1-nicolas.iooss_linux@m4x.org>
        <1495280136.27714.6.camel@perches.com>
Date: Tue, 23 May 2017 22:02:07 -0400
In-Reply-To: <1495280136.27714.6.camel@perches.com> (Joe Perches's message of
        "Sat, 20 May 2017 04:35:36 -0700")
Message-ID: <yq11srfxba8.fsf@oracle.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Joe,

> On Sat, 2017-05-20 at 13:16 +0200, Nicolas Iooss wrote:
>> nsp32_message() and nsp32_dmessage() use printf format strings in order
>> to format a message. Adding __printf attributes helps to detect errors
>> in such format strings at build time, like:

> Does anyone actually have or use these cards any longer?

I doubt it.

-- 
Martin K. Petersen	Oracle Linux Engineering