From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752019AbcISQAt (ORCPT ); Mon, 19 Sep 2016 12:00:49 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:33762 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772AbcISQAr (ORCPT ); Mon, 19 Sep 2016 12:00:47 -0400 To: Baoyou Xie Cc: kashyap.desai@avagotech.com, sumit.saxena@avagotech.com, uday.lingala@avagotech.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn Subject: Re: [PATCH] megaraid_sas: clean function declarations in megaraid_sas_base.c up From: "Martin K. Petersen" Organization: Oracle Corporation References: <1474200479-32042-1-git-send-email-baoyou.xie@linaro.org> Date: Mon, 19 Sep 2016 12:00:21 -0400 In-Reply-To: <1474200479-32042-1-git-send-email-baoyou.xie@linaro.org> (Baoyou Xie's message of "Sun, 18 Sep 2016 20:07:59 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Baoyou" == Baoyou Xie writes: Baoyou> We get a few warnings when building kernel with W=1: Baoyou> drivers/scsi/megaraid/megaraid_sas_fusion.c:281:1: warning: no Baoyou> previous prototype for 'megasas_free_cmds_fusion' Baoyou> [-Wmissing-prototypes] Baoyou> drivers/scsi/megaraid/megaraid_sas_fusion.c:714:1: warning: no Baoyou> previous prototype for 'megasas_ioc_init_fusion' Baoyou> [-Wmissing-prototypes] .... Baoyou> In fact, these functions are declared in Baoyou> drivers/scsi/megaraid/megaraid_sas_base.c, but should be Baoyou> declared in a header file, thus can be recognized in other file. Baoyou> So this patch adds the declarations into Baoyou> drivers/scsi/megaraid/megaraid_sas_fusion.h. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering