From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752444AbcHIB2Z (ORCPT ); Mon, 8 Aug 2016 21:28:25 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:42952 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343AbcHIB2X (ORCPT ); Mon, 8 Aug 2016 21:28:23 -0400 To: Johannes Thumshirn Cc: "Martin K . Petersen" , James Bottomley , Linux SCSI Mailinglist , Linux Kernel Mailinglist , Sreekanth Reddy Subject: Re: [PATCH] mpt3sas: Don't spam logs if logging level is 0 From: "Martin K. Petersen" Organization: Oracle Corporation References: <1470229218-22040-1-git-send-email-jthumshirn@suse.de> Date: Mon, 08 Aug 2016 21:28:02 -0400 In-Reply-To: <1470229218-22040-1-git-send-email-jthumshirn@suse.de> (Johannes Thumshirn's message of "Wed, 3 Aug 2016 15:00:18 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Johannes" == Johannes Thumshirn writes: Johannes> In _scsih_io_done() we test if the ioc->logging_level does Johannes> _not_ have the MPT_DEBUG_REPLY bit set and if it hasn't we Johannes> print the debug messages. This unfortunately is the wrong way Johannes> around. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering