From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751279AbcGNEhZ (ORCPT ); Thu, 14 Jul 2016 00:37:25 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:45380 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbcGNEhR (ORCPT ); Thu, 14 Jul 2016 00:37:17 -0400 To: Johannes Thumshirn Cc: James Bottomley , "Martin K . Petersen" , Linux SCSI Mailinglist , Linux Kernel Mailinglist , Giridhar Malavali , Quinn Tran , Himanshu Madhani Subject: Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR From: "Martin K. Petersen" Organization: Oracle Corporation References: <1467791510-5307-1-git-send-email-jthumshirn@suse.de> Date: Thu, 14 Jul 2016 00:28:37 -0400 In-Reply-To: <1467791510-5307-1-git-send-email-jthumshirn@suse.de> (Johannes Thumshirn's message of "Wed, 6 Jul 2016 09:51:50 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Johannes" == Johannes Thumshirn writes: Johannes> qla2xxx first calls request_irq() and then does the setup of Johannes> the queue entry data needed in the interrupt handlers in when Johannes> using MSI-X. This could lead to a NULL pointer dereference Johannes> when an IRQ fires between the request_irq() call and the Johannes> assignment of the qentry data structure to the rsp-> msix field. A possible case for such a race would be in the kdump Johannes> case when the HBA's IRQs are still enabled but the driver is Johannes> undergoing a new initialisation and thus is not aware of Johannes> already activated IRQs in the HBA. Qlogic folks: Please review! -- Martin K. Petersen Oracle Linux Engineering