From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Alex Dewar <alex.dewar90@gmail.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 0/3] scsi: mpt: Refactor and port to dma_* interface
Date: Thu, 17 Sep 2020 23:26:45 -0400 [thread overview]
Message-ID: <yq15z8bu5v6.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20200916164411.hkpmqigdhgdb66dl@lenovo-laptop> (Alex Dewar's message of "Wed, 16 Sep 2020 17:44:11 +0100")
Alex,
>> Have you tested your changes?
>
> No, as I'm afraid I don't have the hardware.
QEMU supports it, I propose you try testing with that.
I hesitate merging big changes to abandoned drivers unless they've been
tested. It's too easy to miss things during review...
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2020-09-18 3:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 15:28 Alex Dewar
2020-09-03 15:28 ` [PATCH RFC 1/3] scsi: mpt: Remove unnecessary sleepFlag argument from functions Alex Dewar
2020-09-03 15:28 ` [PATCH RFC 2/3] scsi: mpt: Replace a few uses of GFP_ATOMIC with GFP_KERNEL Alex Dewar
2020-09-03 15:28 ` [PATCH RFC 3/3] scsi: mpt: Port from pci_* to dma_* interface Alex Dewar
2020-09-16 2:12 ` [PATCH RFC 0/3] scsi: mpt: Refactor and port " Martin K. Petersen
2020-09-16 16:44 ` Alex Dewar
2020-09-18 3:26 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq15z8bu5v6.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=alex.dewar90@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®