From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934905AbdEXBzu (ORCPT ); Tue, 23 May 2017 21:55:50 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:33639 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765958AbdEXBzh (ORCPT ); Tue, 23 May 2017 21:55:37 -0400 To: Artem Savkov Cc: hare@suse.de, axboe@fb.com, hch@lst.de, martin.petersen@oracle.com, Bart Van Assche , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] Use ctlr directly in rdac_failover_get() From: "Martin K. Petersen" Organization: Oracle Corporation References: <1495232608.2581.3.camel@sandisk.com> <1495267090-8591-1-git-send-email-asavkov@redhat.com> Date: Tue, 23 May 2017 21:55:19 -0400 In-Reply-To: <1495267090-8591-1-git-send-email-asavkov@redhat.com> (Artem Savkov's message of "Sat, 20 May 2017 09:58:10 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Artem, > rdac_failover_get references struct rdac_controller as > ctlr->ms_sdev->handler_data->ctlr for no apparent reason. Besides being > inefficient this also introduces a null-pointer dereference as > send_mode_select() sets ctlr->ms_sdev to NULL before calling > rdac_failover_get(): Applied to 4.12/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering