From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752504AbcHIBQ0 (ORCPT ); Mon, 8 Aug 2016 21:16:26 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:40101 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752150AbcHIBQX (ORCPT ); Mon, 8 Aug 2016 21:16:23 -0400 To: Calvin Owens Cc: Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , "James E.J. Bottomley" , "Martin K. Petersen" , , , , Subject: Re: [PATCH 3/3] mpt3sas: Fix warnings exposed by W=1 From: "Martin K. Petersen" Organization: Oracle Corporation References: <7afa9136f4edf40e29fddf4fcfbc9694724472f2.1469766027.git.calvinowens@fb.com> <094fdbf57487af4f395238c0525b2a560c8f68f0.1469766027.git.calvinowens@fb.com> Date: Mon, 08 Aug 2016 21:16:10 -0400 In-Reply-To: <094fdbf57487af4f395238c0525b2a560c8f68f0.1469766027.git.calvinowens@fb.com> (Calvin Owens's message of "Thu, 28 Jul 2016 21:38:22 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Calvin" == Calvin Owens writes: Calvin> Trivial non-functional changes for a couple annoying things: 1) Calvin> Functions local to files are not declared static, which is Calvin> frustrating when reading the code because it's non-obvious at Calvin> first glance what's actually called from other files. Calvin> 2) Set-but-unused variables abound, presumably to mask Calvin> -Wunused-result errors in the past. None of these are flagged Calvin> today though (with one exception noted below), so remove them. Calvin> Fixing (2) exposed the fact that we improperly ignore the return Calvin> value of scsi_device_reprobe() in _scsih_reprobe_lun(). Fixing Calvin> the calling code to deal with the potential error is Calvin> non-trivial, so for now just WARN(). Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering