From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
kernel-team@android.com, cang@codeaurora.org,
alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org,
martin.petersen@oracle.com, stanley.chu@mediatek.com
Subject: Re: [PATCH v2] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns
Date: Tue, 05 Jan 2021 22:45:01 -0500 [thread overview]
Message-ID: <yq17doqg2j3.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <X+C+oqegC7EI6zDv@google.com> (Jaegeuk Kim's message of "Mon, 21 Dec 2020 07:26:26 -0800")
Jaegeuk,
> When gate_work/ungate_work gets an error during hibern8_enter or exit,
> ufshcd_err_handler()
> ufshcd_scsi_block_requests()
> ufshcd_reset_and_restore()
> ufshcd_clear_ua_wluns() -> stuck
> ufshcd_scsi_unblock_requests()
>
> In order to avoid it, ufshcd_clear_ua_wluns() can be called per recovery flows
> such as suspend/resume, link_recovery, and error_handler.
>
> Fixes: 1918651f2d7e ("scsi: ufs: Clear UAC for RPMB after ufshcd resets")
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Please resubmit instead of replying to an existing patch. Both b4 and
patchwork get confused.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-01-06 3:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 3:31 [PATCH] " Jaegeuk Kim
2020-12-20 22:02 ` Avri Altman
2020-12-21 15:23 ` Jaegeuk Kim
2020-12-21 17:00 ` Avri Altman
2020-12-21 17:19 ` Jaegeuk Kim
2020-12-21 18:05 ` Avri Altman
2020-12-21 19:35 ` Jaegeuk Kim
2020-12-21 20:13 ` Avri Altman
2020-12-21 4:25 ` Can Guo
2020-12-21 15:14 ` Jaegeuk Kim
2020-12-21 15:26 ` [PATCH v2] " Jaegeuk Kim
2021-01-06 3:45 ` Martin K. Petersen [this message]
2021-01-06 4:28 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17doqg2j3.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome