From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752854AbcLEWGT (ORCPT ); Mon, 5 Dec 2016 17:06:19 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:20109 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751998AbcLEWGQ (ORCPT ); Mon, 5 Dec 2016 17:06:16 -0500 To: Rasmus Villemoes Cc: Don Brace , "James E.J. Bottomley" , "Martin K. Petersen" , iss_storagedev@hp.com, esc.storagedev@microsemi.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: hpsa: use %phN for short hex dumps From: "Martin K. Petersen" Organization: Oracle Corporation References: <1480545348-32669-1-git-send-email-linux@rasmusvillemoes.dk> Date: Mon, 05 Dec 2016 17:06:05 -0500 In-Reply-To: <1480545348-32669-1-git-send-email-linux@rasmusvillemoes.dk> (Rasmus Villemoes's message of "Wed, 30 Nov 2016 23:35:47 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Rasmus" == Rasmus Villemoes writes: Rasmus> Passing one instead of 8 or 16 arguments reduces the size of the Rasmus> generated code somewhat: Rasmus> add/remove: 2/3 grow/shrink: 1/4 up/down: 1772/-2137 (-365) Rasmus> There's one more candidate, unique_id_show, but that uses %02X, Rasmus> and I'm not sure it would be ok to start using lowercase there, Rasmus> so I've left it alone for now. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering