From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Ding Hui <dinghui@sangfor.com.cn>
Cc: lduncan@suse.com, cleech@redhat.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, michael.christie@oracle.com,
open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scsi: libiscsi: move init ehwait to iscsi_session_setup()
Date: Tue, 14 Sep 2021 00:05:20 -0400 [thread overview]
Message-ID: <yq18rzzztsa.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20210911135159.20543-1-dinghui@sangfor.com.cn> (Ding Hui's message of "Sat, 11 Sep 2021 21:51:59 +0800")
Ding,
> The commit ec29d0ac29be ("scsi: iscsi: Fix conn use after free during
> resets") move member ehwait from conn to session, but left init ehwait
> in iscsi_conn_setup().
>
> Although a session can only have 1 conn currently, it is better to do
> init ehwait in iscsi_session_setup() to prevent reinit by mistake,
> also in case we can handle multiple conns in the future.
Applied to 5.16/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-09-14 4:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 13:51 Ding Hui
2021-09-13 15:23 ` Mike Christie
2021-09-14 4:05 ` Martin K. Petersen [this message]
2021-09-22 4:45 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18rzzztsa.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=cleech@redhat.com \
--cc=dinghui@sangfor.com.cn \
--cc=jejb@linux.ibm.com \
--cc=lduncan@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®