From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEC24C04AB4 for ; Tue, 14 May 2019 17:12:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CD572084A for ; Tue, 14 May 2019 17:12:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="F3olIyvA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726735AbfENRMo (ORCPT ); Tue, 14 May 2019 13:12:44 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:43428 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726646AbfENRMo (ORCPT ); Tue, 14 May 2019 13:12:44 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4EGwlTx140052; Tue, 14 May 2019 17:12:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=/0OET/cQliuWWpQppXkzvcVEWQheyPLedxuG0KwhB8E=; b=F3olIyvAr2UG5U66ifcnnU/O5AbRFeH1iPbuDnzWVG1lROiJrEJ+9lS+ANbQvm7fqNC9 ygA+91moImm8GsUH+7jeEvbvDIMfb8TTHPvtAjIg0rMFzWuVegFbmJsRd3DM8KA80V0r T9PIARuMrS/TNlgCQq7JQemlH8WJiZtP8b/atfrNduG4G6MuUNiAdOP/ojYpY1QGdNky 8ggHRRNWwQBMQHF6KQuZxSIAvYVahJ+6t5dkxzbaMxbAkAGZF9pt6DDMV0clcyczRUrY SC8XdQhEOYj537Qptu0H1sbaTfHWJb/nW39qeuQsyaFJFGl9FYykimrTy1xBu4p+e73Z NQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2sdq1qfhx6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 May 2019 17:12:37 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4EHBJ92178859; Tue, 14 May 2019 17:12:37 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 2sdmeb72c0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 May 2019 17:12:36 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x4EHCWOj016898; Tue, 14 May 2019 17:12:33 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 14 May 2019 10:12:32 -0700 To: Colin King Cc: QLogic-Storage-Upstream@qlogic.com, "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: bnx2fc: fix incorrect cast to u64 on shift operation From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190504164829.26631-1-colin.king@canonical.com> Date: Tue, 14 May 2019 13:12:30 -0400 In-Reply-To: <20190504164829.26631-1-colin.king@canonical.com> (Colin King's message of "Sat, 4 May 2019 17:48:29 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9257 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=771 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905140118 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9257 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=822 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905140118 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin, > Currently an int is being shifted and the result is being cast to a > u64 which leads to undefined behaviour if the shift is more than 31 > bits. Fix this by casting the integer value 1 to u64 before the shift > operation. Applied to 5.2/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering