From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752760AbcIBK7I (ORCPT ); Fri, 2 Sep 2016 06:59:08 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:23264 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbcIBK7G (ORCPT ); Fri, 2 Sep 2016 06:59:06 -0400 To: Baoyou Xie Cc: vinholikatti@gmail.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@linaro.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] scsi: ufs: add missing declaration in ufshcd.h From: "Martin K. Petersen" Organization: Oracle Corporation References: <1472371282-14691-1-git-send-email-baoyou.xie@linaro.org> Date: Fri, 02 Sep 2016 06:58:55 -0400 In-Reply-To: <1472371282-14691-1-git-send-email-baoyou.xie@linaro.org> (Baoyou Xie's message of "Sun, 28 Aug 2016 16:01:22 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Baoyou" == Baoyou Xie writes: Baoyou> We get 1 warning about global functions without a declaration in Baoyou> the scsi ufshcd driver when building with W=1: Baoyou> drivers/scsi/ufs/ufshcd.c:1991:5: warning: no previous prototype Baoyou> for 'ufshcd_query_descriptor_retry' [-Wmissing-prototypes] Baoyou> in fact, this function is implemented in ufshcd.c and exported Baoyou> but need to be declared in header file. ufshcd_query_descriptor_retry doesn't appear to be used outside of ufshcd.c. -- Martin K. Petersen Oracle Linux Engineering