From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758153AbdKPAIn (ORCPT ); Wed, 15 Nov 2017 19:08:43 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:32126 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753038AbdKPAIe (ORCPT ); Wed, 15 Nov 2017 19:08:34 -0500 To: Hannes Reinecke Cc: "Martin K. Petersen" , James Bottomley , Christoph Hellwig , Linus Torvalds , linux-scsi@vger.kernel.org, Linux Kernel Mailinglist , Hannes Reinecke Subject: Re: [PATCH] scsi: Use 'blist_flags_t' for scsi_devinfo flags From: "Martin K. Petersen" Organization: Oracle Corporation References: <1510744050-53682-1-git-send-email-hare@suse.de> Date: Wed, 15 Nov 2017 19:07:50 -0500 In-Reply-To: <1510744050-53682-1-git-send-email-hare@suse.de> (Hannes Reinecke's message of "Wed, 15 Nov 2017 12:07:30 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hannes, > As per recommendation from Linus we should be using a distinct > type for blacklist flags. > -#define BLIST_MAX_1024 ((__force __u32 __bitwise)(1 << 30)) > +#define BLIST_MAX_1024 ((__force blist_flags_t)(1 << 30)) You are missing: /* Use UNMAP limit for WRITE SAME */ #define BLIST_UNMAP_LIMIT_WS ((__force blist_flags_t)(1 << 31)) I'll fix it up... -- Martin K. Petersen Oracle Linux Engineering