Re: [PATCH 0 of 7] Block/SCSI Data Integrity Support

["Martin K. Petersen" <martin.petersen@oracle.com>]

>>>>> "Jeff" == Jeff Moyer <jmoyer@redhat.com> writes:

Jeff> So, is it safe to say that the library routines for
Jeff> integrity-aware file systems have not been tested at all?
Jeff> Specifically, I'm talking about: bio_integrity_tag_size
Jeff> bio_integrity_set_tag bio_integrity_get_tag

I have not tried using them from within a filesystem, if that's what
you mean.  But I have attached random strings to bios and read them
back later.


Jeff> gcc (GCC) 4.1.2 20071124 (Red Hat 4.1.2-41)

Ok, I'm trying to chase down a 5.2 box to figure out what the problem
is.  Maybe I'll just move that function to the header file.


Jeff> I did a new clone (just to be sure I got your change) and I get
Jeff> the same problem.  I also can't see the changeset in the log, so
Jeff> are you sure you pushed it?

Yup, it's there.


Jeff> I got rid of the inline in the definition in bio.h.  The .c file
Jeff> didn't define the function as inline, so I didn't have to change
Jeff> it.  It seems to be building now.

The problem is that your gcc is unhappy about the fact that the
inlined function is defined elsewhere.  The gcc info page said only
declare it inline in the header and not the declaration.  The change I
pushed removed inline from the .c file.  But that didn't help.

-- 
Martin K. Petersen	Oracle Linux Engineering