From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937859AbdAEFcQ (ORCPT ); Thu, 5 Jan 2017 00:32:16 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:34139 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933740AbdAEFcP (ORCPT ); Thu, 5 Jan 2017 00:32:15 -0500 To: Colin King Cc: QLogic-Storage-Upstream@cavium.com, "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: qedi: return via va_end to match corresponding va_start From: "Martin K. Petersen" Organization: Oracle Corporation References: <20161216141043.22324-1-colin.king@canonical.com> Date: Thu, 05 Jan 2017 00:32:04 -0500 In-Reply-To: <20161216141043.22324-1-colin.king@canonical.com> (Colin King's message of "Fri, 16 Dec 2016 14:10:43 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Colin" == Colin King writes: Colin> Although on most systems va_end is a no-op, it is good practice Colin> to use va_end on the function return path, especially since the Colin> va_start documenation states: Colin> "Each invocation of va_start() must be matched by a Colin> corresponding Colin> invocation of va_end() in the same function." Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering