From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752385AbcHIBMY (ORCPT ); Mon, 8 Aug 2016 21:12:24 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:31572 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751590AbcHIBMX (ORCPT ); Mon, 8 Aug 2016 21:12:23 -0400 To: Calvin Owens Cc: Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , "James E.J. Bottomley" , "Martin K. Petersen" , , , , Subject: Re: [PATCH 1/3] mpt3sas: Eliminate conditional locking in mpt3sas_scsih_issue_tm() From: "Martin K. Petersen" Organization: Oracle Corporation References: <7afa9136f4edf40e29fddf4fcfbc9694724472f2.1469766027.git.calvinowens@fb.com> Date: Mon, 08 Aug 2016 21:12:11 -0400 In-Reply-To: <7afa9136f4edf40e29fddf4fcfbc9694724472f2.1469766027.git.calvinowens@fb.com> (Calvin Owens's message of "Thu, 28 Jul 2016 21:38:20 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Calvin" == Calvin Owens writes: Calvin> This flag that conditionally acquires the mutex is confusing and Calvin> prone to bugginess: refactor it into two separate function Calvin> calls, and make the unlocked one complain if it's called outside Calvin> the mutex. Applied to 4.9/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering