From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754441AbcFUBNF (ORCPT ); Mon, 20 Jun 2016 21:13:05 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:24217 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751491AbcFUBM7 (ORCPT ); Mon, 20 Jun 2016 21:12:59 -0400 To: Arnd Bergmann Cc: "James E.J. Bottomley" , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] scsi: wd7000: print sector number as 64-bit From: "Martin K. Petersen" Organization: Oracle Corporation References: <20160615204231.3784044-1-arnd@arndb.de> <4878482.cSGU6mK9NX@wuerfel> Date: Mon, 20 Jun 2016 21:12:50 -0400 In-Reply-To: <4878482.cSGU6mK9NX@wuerfel> (Arnd Bergmann's message of "Wed, 15 Jun 2016 22:54:49 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Arnd" == Arnd Bergmann writes: As sector_t can be 32-bit wide, this adds a cast to 'u64' and prints that with the correct format. The change to use no_printk() [...] + dprintk("wd7000_biosparam: dev=%s, size=%lld, ", + bdevname(bdev, b), (s64)capacity); s64? Why not unsigned long long like we usually do with sector_t? -- Martin K. Petersen Oracle Linux Engineering