From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751812AbcDOU4p (ORCPT ); Fri, 15 Apr 2016 16:56:45 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:28773 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746AbcDOU4n (ORCPT ); Fri, 15 Apr 2016 16:56:43 -0400 To: John Garry Cc: , , , , , , Subject: Re: [PATCH 0/3] hisi_sas: device id/IPTT collision workaround From: "Martin K. Petersen" Organization: Oracle Corporation References: <1460727398-102091-1-git-send-email-john.garry@huawei.com> Date: Fri, 15 Apr 2016 16:56:27 -0400 In-Reply-To: <1460727398-102091-1-git-send-email-john.garry@huawei.com> (John Garry's message of "Fri, 15 Apr 2016 21:36:35 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "John" == John Garry writes: John> This patchset introduces a workaround to a hw quirk in the John> HiSilicon SAS controller v2 hw. John> The quirk is as follows: When a SATA and SAS frame arrives at the John> host at the same time the frames may be swapped under this John> condition: SATA device id bit [10:0] == SAS frame IPTT bit [10:0] John> The workaround is to ensure these 2 values never match. The John> workaround algorithm is as follows: - SATA device id bit0 always 0 John> - SATA IPTT has no restriction - SAS IPTT bit0 always 1 - SAS John> device id has no restriction John> The major restriction of this workaround is the SAS IPTT range is John> halved, but this should be ok as testing has shown that even using John> half the IPTT range does not affect performance. Applied to 4.7/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering