From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: John Garry <john.garry@huawei.com>
Cc: <martin.petersen@oracle.com>, <jejb@linux.vnet.ibm.com>,
<john.garry2@mail.dcu.ie>, <lambert.quentin@gmail.com>,
<xuwei5@hisilicon.com>, <linux-kernel@vger.kernel.org>,
<linux-scsi@vger.kernel.org>, <zhangfei.gao@linaro.org>,
<linuxarm@huawei.com>, Xiaofei Tan <tanxiaofei@huawei.com>
Subject: Re: [PATCH] scsi: hisi_sas: fix free'ing in probe and remove
Date: Mon, 05 Dec 2016 16:55:23 -0500 [thread overview]
Message-ID: <yq1fum2vy5w.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1480434357-63730-1-git-send-email-john.garry@huawei.com> (John Garry's message of "Tue, 29 Nov 2016 23:45:57 +0800")
>>>>> "John" == John Garry <john.garry@huawei.com> writes:
John> This patch addresses 4 problems in the module probe/remove:
John> - When hisi_sas_shost_alloc() fails after we alloc shost memory,
John> we should free shost memory before the function returns.
John> - When hisi_sas_probe() fails after we alloc the HBA memories,
John> we should also free the HBA memories.
John> - We should free shost memory at the end of hisi_sas_remove().
John> - sha->core.shost is set twice, so remove extra set.
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2016-12-05 21:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 15:45 John Garry
2016-12-02 13:43 ` Quentin Lambert
2016-12-05 21:55 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fum2vy5w.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry2@mail.dcu.ie \
--cc=john.garry@huawei.com \
--cc=lambert.quentin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=tanxiaofei@huawei.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®