From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Gu Zheng <guz.fnst@cn.fujitsu.com>
Cc: Jens <axboe@kernel.dk>, <martin.petersen@oracle.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Kent <kmo@daterainc.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH] bio-integrity: add "bip_max_vcnt" into struct bio_integrity_payload
Date: Sun, 29 Jun 2014 19:15:49 -0400 [thread overview]
Message-ID: <yq1fvin9uje.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <53AD4385.8080105@cn.fujitsu.com> (Gu Zheng's message of "Fri, 27 Jun 2014 18:12:21 +0800")
>>>>> "Gu" == Gu Zheng <guz.fnst@cn.fujitsu.com> writes:
[Sorry about the delay. I'm on vacation right now.]
Gu> But it seems that bip_integrity_vecs() will return the wrong number
Gu> if the bio is not based on any bio_set for some reason(bio->bi_pool
Gu> == NULL), because in that case, the bip_inline_vecs[0] is malloced
Gu> directly. So here we add the bip_max_vcnt to record the count of
Gu> vector slots, and cleanup the function bip_integrity_vecs().
I'm in agreement with your fix.
However, I'm still not sure what the use case is for bios without an
associated bioset. I do not see any callers that pass in a NULL bioset.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2014-06-29 23:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 10:12 Gu Zheng
2014-06-29 23:15 ` Martin K. Petersen [this message]
2014-06-30 3:39 ` Gu Zheng
2014-06-30 15:56 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fvin9uje.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=guz.fnst@cn.fujitsu.com \
--cc=kmo@daterainc.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome