From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
Chandrakanth patil <chandrakanth.patil@broadcom.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] scsi: megaraid: remove redundant assignment to variable retval
Date: Tue, 23 Jan 2024 21:38:35 -0500 [thread overview]
Message-ID: <yq1h6j3xxp7.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20240118121441.2533620-1-colin.i.king@gmail.com> (Colin Ian King's message of "Thu, 18 Jan 2024 12:14:41 +0000")
Colin,
> The variable retval is being assigned a value that is not being read
> afterwards. The assignment is redundant and can be removed.
Applied to 6.9/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2024-01-24 2:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 12:14 Colin Ian King
2024-01-24 2:38 ` Martin K. Petersen [this message]
2024-01-30 2:26 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1h6j3xxp7.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=chandrakanth.patil@broadcom.com \
--cc=colin.i.king@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®