From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Chengfeng Ye <dg573847474@gmail.com>
Cc: hare@suse.de, jejb@linux.ibm.com, martin.petersen@oracle.com,
bigeasy@linutronix.de, dave@stgolabs.net, satishkh@cisco.com,
sebaddel@cisco.com, kartilak@cisco.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock
Date: Mon, 21 Aug 2023 17:02:41 -0400 [thread overview]
Message-ID: <yq1h6os6rdl.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20230817074708.7509-1-dg573847474@gmail.com> (Chengfeng Ye's message of "Thu, 17 Aug 2023 07:47:08 +0000")
Chengfeng,
> There is a long call chain that &fip->ctlr_lock is acquired by isr
> fnic_isr_msix_wq_copy() under hard irq context. Thus other process
> context code acquiring the lock should disable irq, otherwise deadlock
> could happen if the irq preempt the execution while the lock is held
> in process context on the same CPU.
Applied to 6.6/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-08-21 21:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 7:47 Chengfeng Ye
2023-08-21 21:02 ` Martin K. Petersen [this message]
2023-08-25 1:12 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1h6os6rdl.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=bigeasy@linutronix.de \
--cc=dave@stgolabs.net \
--cc=dg573847474@gmail.com \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=kartilak@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®