mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Shaohua Li <shli@fb.com>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	sitsofe@yahoo.com, snitzer@redhat.com, axboe@fb.com,
	martin.petersen@oracle.com, Kernel-team@fb.com
Subject: Re: [PATCH] block: correctly fallback for zeroout
Date: Thu, 02 Jun 2016 23:06:56 -0400	[thread overview]
Message-ID: <yq1h9dbrmwf.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20160529064728.GA14383@infradead.org> (Christoph Hellwig's message of "Sat, 28 May 2016 23:47:28 -0700")

>>>>> "Christoph" == Christoph Hellwig <hch@infradead.org> writes:

Christoph> As part of that I also removed the strange EOPNOTSUPP ignore,
Christoph> but Mike reverted it just because it changed something in the
Christoph> dm testsuite.

Mike?

Christoph> I still believe we should never ignore it in this helper, and
Christoph> only do so in callers that believe it's the right thing.

Yeah.

I really wish EOPNOTSUPP would just go away except for ioctl callers.
Now that we have real bi_error I don't understand why we need it.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2016-06-03  3:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-26 18:08 Shaohua Li
2016-05-29  6:47 ` Christoph Hellwig
2016-06-03  3:06   ` Martin K. Petersen [this message]
2016-06-03  3:54     ` Mike Snitzer
2016-06-07  2:32       ` Martin K. Petersen
2016-06-07  6:38         ` Christoph Hellwig
2016-06-10  2:05           ` Martin K. Petersen
     [not found] ` <20160527054918.GA9521@sucs.org>
2016-05-28  9:27   ` [PATCH] " Sitsofe Wheeler
2016-06-02 16:58     ` Shaohua Li
2016-06-02 17:02       ` Martin K. Petersen
2016-06-03  2:56   ` Martin K. Petersen
2016-06-03  3:26 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1h9dbrmwf.fsf@sermon.lab.mkp.net \
    --to=martin.petersen@oracle.com \
    --cc=Kernel-team@fb.com \
    --cc=axboe@fb.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shli@fb.com \
    --cc=sitsofe@yahoo.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome