From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Jan Kara <jack@suse.cz>,
axboe@kernel.dk, lucho@ionkov.net, ericvh@gmail.com,
tytso@mit.edu, viro@zeniv.linux.org.uk, rminnich@sandia.gov,
martin.petersen@oracle.com, neilb@suse.de, david@fromorbit.com,
gnehzuil.liu@gmail.com, linux-kernel@vger.kernel.org,
hch@infradead.org, linux-fsdevel@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>,
adilger.kernel@dilger.ca, bharrosh@panasas.com,
jlayton@samba.org, linux-ext4@vger.kernel.org,
hirofumi@mail.parknet.co.jp
Subject: Re: [PATCH 4/6] block: Optionally snapshot page contents to provide stable pages during write
Date: Wed, 16 Jan 2013 22:26:36 -0500 [thread overview]
Message-ID: <yq1hamgjxqr.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20130117030132.GK6426@blackbox.djwong.org> (Darrick J. Wong's message of "Wed, 16 Jan 2013 19:01:32 -0800")
>>>>> "Darrick" == Darrick J Wong <darrick.wong@oracle.com> writes:
>> Umm, why did you move this hunk?
Darrick> I moved it so that the integrity data are generated against the
Darrick> contents of the bounce buffer because the write paths don't
Darrick> wait for writeback to finish if the snapshotting mode is
Darrick> enabled, which means (I think) that programs can wander in and
Darrick> scribble on the original page in between bio_integrity_prep and
Darrick> blk_queue_bounce.
It's also important that bio_integrity_prep() is run after partition
remapping has taken place. But it looks like that's still the case after
your change.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2013-01-17 3:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 5:42 [PATCH v2.4 0/3] mm/fs: Remove unnecessary waiting for stable pages Darrick J. Wong
2013-01-15 5:42 ` [PATCH 1/6] bdi: Allow block devices to say that they require stable page writes Darrick J. Wong
2013-01-15 5:42 ` [PATCH 2/6] mm: Only enforce stable page writes if the backing device requires it Darrick J. Wong
2013-01-15 10:19 ` Jan Kara
2013-01-15 10:59 ` Steven Whitehouse
2013-01-18 1:26 ` Darrick J. Wong
2013-01-15 5:42 ` [PATCH 3/6] 9pfs: Fix filesystem to wait for stable page writeback Darrick J. Wong
2013-01-15 5:43 ` [PATCH 4/6] block: Optionally snapshot page contents to provide stable pages during write Darrick J. Wong
2013-01-16 2:00 ` Jan Kara
2013-01-17 3:01 ` Darrick J. Wong
2013-01-17 3:26 ` Martin K. Petersen [this message]
2013-01-17 10:32 ` Jan Kara
2013-01-15 5:43 ` [PATCH 5/6] ocfs2: Wait for page writeback to provide stable pages Darrick J. Wong
2013-01-15 10:15 ` Jan Kara
2013-01-15 5:43 ` [PATCH 6/6] ubifs: " Darrick J. Wong
2013-01-15 22:46 ` [PATCH v2.4 0/3] mm/fs: Remove unnecessary waiting for " Andrew Morton
2013-01-16 0:22 ` Darrick J. Wong
2013-01-16 0:33 ` Andrew Morton
2013-01-17 2:49 ` Darrick J. Wong
2013-01-17 4:43 ` Andrew Morton
2013-01-18 1:18 ` Darrick J. Wong
2013-01-19 1:12 [PATCH v2.5 " Darrick J. Wong
2013-01-19 1:13 ` [PATCH 4/6] block: Optionally snapshot page contents to provide stable pages during write Darrick J. Wong
2013-01-21 14:12 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1hamgjxqr.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@kernel.dk \
--cc=bharrosh@panasas.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=ericvh@gmail.com \
--cc=gnehzuil.liu@gmail.com \
--cc=hch@infradead.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.cz \
--cc=jlayton@samba.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=luto@amacapital.net \
--cc=neilb@suse.de \
--cc=rminnich@sandia.gov \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome