From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Mike Snitzer <snizer@redhat.com>,
James Bottomley <James.Bottomley@suse.de>,
"Rafael J. Wysocki" <rjw@sisk.pl>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [Regression] Please revert a91a2785b20
Date: Mon, 28 Mar 2011 18:45:37 -0400 [thread overview]
Message-ID: <yq1hbamkgoe.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <alpine.LFD.2.00.1103290006070.2774@localhost6.localdomain6> (Thomas Gleixner's message of "Tue, 29 Mar 2011 00:35:20 +0200 (CEST)")
>>>>> "Thomas" == Thomas Gleixner <tglx@linutronix.de> writes:
Thomas,
Thomas> But the changelog does not give the courtesy of explaining these
Thomas> changes. Also there is no fcking reason why the kernel cannot
Thomas> deal with the missing integrity capabilities of a drive just by
Thomas> emitting a warning msg and dealing gracefully with the outcome.
My mistake. I was made aware of it earlier today and I'm working on a
patch. Surprised we didn't see any reports of this in -next. It's been
in there for a while.
Thomas> All my RAID setups have been working perfectly fine until now,
Thomas> so what's the rationale to break this?
People were complaining about excessive mempool usage with the block
integrity bits enabled (thanks to MD and DM allocating a bioset per
device to prevent deadlocks).
Making allocation conditional meant we had to deal with memory
allocation errors in the setup path. I tested various combinations of on
and off but apparently not all off. Sorry about that.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2011-03-28 22:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 22:35 Thomas Gleixner
2011-03-28 22:43 ` Thomas Gleixner
2011-03-28 23:03 ` Mike Snitzer
2011-03-29 6:59 ` Jens Axboe
2011-03-29 13:20 ` Mike Snitzer
2011-03-29 13:35 ` James Bottomley
2011-03-29 13:42 ` Martin K. Petersen
2011-03-29 13:58 ` Need to refactor DM's integrity profile support a bit (was: Re: Please revert a91a2785b20) Mike Snitzer
2011-04-01 17:42 ` [PATCH] dm: improve block integrity support Mike Snitzer
2011-04-14 14:09 ` Mike Snitzer
2011-04-14 14:42 ` Mike Snitzer
2011-04-15 4:57 ` Martin K. Petersen
2011-04-05 2:09 ` Please revert a91a2785b20 NeilBrown
2011-03-28 22:45 ` Martin K. Petersen [this message]
2011-03-28 23:03 ` [Regression] " Thomas Gleixner
2011-03-29 0:09 ` Martin K. Petersen
2011-03-29 0:11 ` Martin K. Petersen
2011-03-29 2:32 ` Thomas Gleixner
2011-03-29 5:32 ` Giacomo Catenazzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1hbamkgoe.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=snizer@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome