From: "Martin K. Petersen (Oracle)" <mkp@kernel.org>
To: Runyu Xiao <runyu.xiao@seu.edu.cn>
Cc: Jack Wang <jinpu.wang@cloud.ionos.com>,
"James E . J . Bottomley"
<James.Bottomley@HansenPartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Jianhao Xu <jianhao.xu@seu.edu.cn>
Subject: Re: [PATCH] scsi: pm8001: use rollback index when freeing MSI-X vectors
Date: Fri, 28 Aug 2026 21:36:57 -0400 [thread overview]
Message-ID: <yq1ik4tk8r6.fsf@mail.kernel.org> (raw)
In-Reply-To: <20260824113618.2239100-1-runyu.xiao@seu.edu.cn> (Runyu Xiao's message of "Mon, 24 Aug 2026 19:36:18 +0800")
Runyu,
> pm8001_request_msix() unwinds previously registered handlers with
> free_irq() when request_irq() fails. The rollback loop uses the
> failing index i for every iteration instead of the already registered
> vector index j.
>
> That passes the wrong IRQ/dev_id pair to free_irq() and leaves the
> earlier handlers installed. Use j for both pci_irq_vector() and the
> matching irq_vector entry in the rollback loop.
Applied to 7.3/scsi-staging, thanks!
--
Martin K. Petersen
prev parent reply other threads:[~2026-08-29 1:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 11:36 Runyu Xiao
2026-08-28 11:30 ` Jinpu Wang
2026-08-29 1:36 ` Martin K. Petersen (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ik4tk8r6.fsf@mail.kernel.org \
--to=mkp@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jianhao.xu@seu.edu.cn \
--cc=jinpu.wang@cloud.ionos.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=runyu.xiao@seu.edu.cn \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®