mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Yihang Li <liyihang9@huawei.com>
Cc: <martin.petersen@oracle.com>,
	<James.Bottomley@HansenPartnership.com>,
	<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linuxarm@huawei.com>, <liuyonglong@huawei.com>,
	<prime.zeng@hisilicon.com>
Subject: Re: [PATCH v2 0/4] hisi_sas: Misc patches and cleanups
Date: Fri, 11 Apr 2025 20:45:34 -0400	[thread overview]
Message-ID: <yq1jz7qjjtw.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250331123349.99591-1-liyihang9@huawei.com> (Yihang Li's message of "Mon, 31 Mar 2025 20:33:45 +0800")


Hi Yihang!

> This series contains some minor bugfix and general tidying:
> - Ignore the soft reset result by calling I_T_nexus after the SATA disk
>   is soft reset
> - General minor tidying

v3_hw won't compile after applying this series:

drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function ‘debugfs_show_row_64_v3_hw’:
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:3718:27: error: ‘TWO_PARA_PER_LINE’ undeclared (first use in this function)
 3718 |                 if (!(i % TWO_PARA_PER_LINE))
      |                           ^~~~~~~~~~~~~~~~~
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:3718:27: note: each undeclared identifier is reported only once for each function it appears in
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function ‘debugfs_show_row_32_v3_hw’:
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:3734:27: error: ‘FOUR_PARA_PER_LINE’ undeclared (first use in this function)
 3734 |                 if (!(i % FOUR_PARA_PER_LINE))
      |                           ^~~~~~~~~~~~~~~~~~
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function ‘debugfs_create_files_v3_hw’:
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:3896:19: error: ‘NAME_BUF_SIZE’ undeclared (first use in this function); did you mean ‘PROT_BUF_SIZE’?
 3896 |         char name[NAME_BUF_SIZE];
      |                   ^~~~~~~~~~~~~
      |                   PROT_BUF_SIZE
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:3896:14: error: unused variable ‘name’ [-Werror=unused-variable]
 3896 |         char name[NAME_BUF_SIZE];
      |              ^~~~
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function ‘debugfs_trigger_dump_v3_hw_write’:
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:3974:18: error: ‘DUMP_BUF_SIZE’ undeclared (first use in this function); did you mean ‘DUMMY_BUF_SIZE’?
 3974 |         char buf[DUMP_BUF_SIZE];
      |                  ^~~~~~~~~~~~~
      |                  DUMMY_BUF_SIZE
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:3974:14: error: unused variable ‘buf’ [-Werror=unused-variable]
 3974 |         char buf[DUMP_BUF_SIZE];
      |              ^~~
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function ‘debugfs_bist_linkrate_v3_hw_write’:
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4040:19: error: ‘BIST_BUF_SIZE’ undeclared (first use in this function); did you mean ‘PROT_BUF_SIZE’?
 4040 |         char kbuf[BIST_BUF_SIZE] = {}, *pkbuf;
      |                   ^~~~~~~~~~~~~
      |                   PROT_BUF_SIZE
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4040:14: error: unused variable ‘kbuf’ [-Werror=unused-variable]
 4040 |         char kbuf[BIST_BUF_SIZE] = {}, *pkbuf;
      |              ^~~~
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function ‘debugfs_bist_code_mode_v3_hw_write’:
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4115:19: error: ‘BIST_BUF_SIZE’ undeclared (first use in this function); did you mean ‘PROT_BUF_SIZE’?
 4115 |         char kbuf[BIST_BUF_SIZE] = {}, *pkbuf;
      |                   ^~~~~~~~~~~~~
      |                   PROT_BUF_SIZE
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4115:14: error: unused variable ‘kbuf’ [-Werror=unused-variable]
 4115 |         char kbuf[BIST_BUF_SIZE] = {}, *pkbuf;
      |              ^~~~
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function ‘debugfs_bist_mode_v3_hw_write’:
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4247:19: error: ‘BIST_BUF_SIZE’ undeclared (first use in this function); did you mean ‘PROT_BUF_SIZE’?
 4247 |         char kbuf[BIST_BUF_SIZE] = {}, *pkbuf;
      |                   ^~~~~~~~~~~~~
      |                   PROT_BUF_SIZE
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4247:14: error: unused variable ‘kbuf’ [-Werror=unused-variable]
 4247 |         char kbuf[BIST_BUF_SIZE] = {}, *pkbuf;
      |              ^~~~
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c: In function ‘debugfs_phy_down_cnt_init_v3_hw’:
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4794:19: error: ‘NAME_BUF_SIZE’ undeclared (first use in this function); did you mean ‘PROT_BUF_SIZE’?
 4794 |         char name[NAME_BUF_SIZE];
      |                   ^~~~~~~~~~~~~
      |                   PROT_BUF_SIZE
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c:4794:14: error: unused variable ‘name’ [-Werror=unused-variable]
 4794 |         char name[NAME_BUF_SIZE];
      |              ^~~~
cc1: all warnings being treated as errors

Please fix, thanks!

-- 
Martin K. Petersen

  parent reply	other threads:[~2025-04-12  0:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-31 12:33 Yihang Li
2025-03-31 12:33 ` [PATCH v2 1/4] scsi: hisi_sas: Use macro instead of magic number Yihang Li
2025-03-31 12:33 ` [PATCH v2 2/4] scsi: hisi_sas: Code style cleanup Yihang Li
2025-03-31 12:33 ` [PATCH v2 3/4] scsi: hisi_sas: Call I_T_nexus after soft reset for SATA disk Yihang Li
2025-03-31 12:33 ` [PATCH v2 4/4] scsi: hisi_sas: Wait until eh is recovered Yihang Li
2025-04-12  0:45 ` Martin K. Petersen [this message]
2025-04-14  1:10   ` [PATCH v2 0/4] hisi_sas: Misc patches and cleanups Yihang Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1jz7qjjtw.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=liuyonglong@huawei.com \
    --cc=liyihang9@huawei.com \
    --cc=prime.zeng@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®