From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: kashyap.desai@broadcom.com
Cc: Harshvardhan Jha <harshvardhan.jha@oracle.com>,
sumit.saxena@broadcom.com,
shivasharan.srikanteshwara@broadcom.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, megaraidlinux.pdl@broadcom.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
dan.carpenter@oracle.com
Subject: Re: [PATCH] scsi: megaraid_mm: Fix end of loop tests for list_for_each_entry
Date: Mon, 26 Jul 2021 23:20:11 -0400 [thread overview]
Message-ID: <yq1k0lcqw8v.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20210708074642.23599-1-harshvardhan.jha@oracle.com> (Harshvardhan Jha's message of "Thu, 8 Jul 2021 13:16:42 +0530")
Kashyap,
> The list_for_each_entry() iterator, "adapter" in this code, can never be
> NULL. If we exit the loop without finding the correct adapter then
> "adapter" points invalid memory that is an offset from the list head.
> This will eventually lead to memory corruption and presumably a kernel
> crash.
Please review. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-07-27 3:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 7:46 Harshvardhan Jha
2021-07-27 3:20 ` Martin K. Petersen [this message]
2021-07-27 10:55 ` Sumit Saxena
2021-07-29 3:37 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1k0lcqw8v.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=harshvardhan.jha@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®